    1
    2
    3
    4
    5
    6
    7
    8
    9
    10
    11
    12
    13
    14
    15
    16
    17
    18
    19
    20
    21
    22
    23
    24
    25
    26
    27
    28
    29
    30
    31
    32
    33
    34
    35
    36
    37
    38
    39
    40
    41
    42
    43
    44
    45
    46
    47
    48
    49
    50
    51
    52
    53
    54
    55
    56
    57
    58
    59
    60
    61
    62
    63
    64
    65
    66
    67
    68
    69
    70
    71
    72
    73
    74
    75
    76
    77
    78
    79
    80
    81
    82
    83
    84
    85
    86
    87
    88
    89
    90
    91
    92
    93
    94
    95
    96
    97
    98
    99
    100
    101
    102
    103
    104
    105
    106
    107
    108
    109
    110
    111
    112
    113
    114
    115
    116
    117
    118
    119
    120
    121
    122
    123
    124
    125
    126
    127
    128
    129
    130
    131
    132
    133
    134
    135
    136
    137
    138
    139
    140
    141
    142
    143
    144
    145
    146
    147
    148
    149
    150
    151
    152
    153
    154
    155
    156
    157
    158
    159
    160
    161
    162
    163
    164
    165
    166
    167
    168
    169
    170
    171
    172
    173
    174
    175
    176
    177
    178
    179
    180
    181
    182
    183
    184
    185
    186
    187
    188
    189
    190
    191
    192
    193
    194
    195
    196
    197
    198
    199
    200
    201
    202
    203
    204
    205
    206
    207
    208
    209
    210
    211
    212
    213
    214
    215
    216
    217
    218
    219
    220
    221
    222
    223
    224
    225
    226
    227
    228
    229
    230
    231
    232
    233
    234
    235
    236
    237
    238
    239
    240
    241
    242
    243
    244
    245
    246
    247
    248
    249
    250
    251
    252
    253
    254
    255
    256
    257
    258
    259
    260
    261
    262
    263
    264
    265
    266
    267
    268
    269
    270
    271
    272
    273
    274
    275
    276
    277
    278
    279
    280
    281
    282
    283
    284
    285
    286
    287
    288
    289
    290
    291
    292
    293
    294
    295
    296
    297
    298
    299
    300
    301
    302
    303
    304
    305
    306
    307
    308
    309
    310
    311
    312
    313
    314
    315
    316
    317
    318
    319
    320
    321
    322
    323
    324
    325
    326
    327
    328
    329
    330
    331
    332
    333
    334
    335
    336
    337
    338
    339
    340
    341
    342
    343
    344
    345
    346
    347
    348
    349
    350
    351
    352
    353
    354
    355
    356
    357
    358
    359
    360
    361
    362
    363
    364
    365
    366
    367
    368
    369
    370
    371
    372
    373
    374
    375
    376
    377
    378
    379
    380
    381
    382
    383
    384
    385
    386
    387
    388
    389
    390
    391
    392
    393
    394
    395
    396
    397
    398
    399
    400
    401
    402
    403
    404
    405
    406
    407
    408
    409
    410
    411
    412

    //! HTTP Authentication middleware.

    use std::{
        future::Future,
        marker::PhantomData,
        pin::Pin,
        rc::Rc,
        sync::Arc,
        task::{Context, Poll},
    };

    use actix_web::{
        body::{EitherBody, MessageBody},
        dev::{Service, ServiceRequest, ServiceResponse, Transform},
        Error,
    };
    use futures_core::ready;
    use futures_util::future::{self, FutureExt as _, LocalBoxFuture, TryFutureExt as _};

    use crate::extractors::{basic, bearer, AuthExtractor};

    /// Middleware for checking HTTP authentication.
    ///
    /// If there is no `Authorization` header in the request, this middleware returns an error
    /// immediately, without calling the `F` callback.
    ///
    /// Otherwise, it will pass both the request and the parsed credentials into it. In case of
    /// successful validation `F` callback is required to return the `ServiceRequest` back.
    #[derive(Debug, Clone)]
    pub struct HttpAuthentication<T, F>
    where
        T: AuthExtractor,
    {
        process_fn: Arc<F>,
        _extractor: PhantomData<T>,
    }

    impl<T, F, O> HttpAuthentication<T, F>
    where
        T: AuthExtractor,
        F: Fn(ServiceRequest, T) -> O,
        O: Future<Output = Result<ServiceRequest, Error>>,
    {
        /// Construct `HttpAuthentication` middleware with the provided auth extractor `T` and
        /// validation callback `F`.
        pub fn with_fn(process_fn: F) -> HttpAuthentication<T, F> {
            HttpAuthentication {
                process_fn: Arc::new(process_fn),
                _extractor: PhantomData,
            }
        }
    }

    impl<F, O> HttpAuthentication<basic::BasicAuth, F>
    where
        F: Fn(ServiceRequest, basic::BasicAuth) -> O,
        O: Future<Output = Result<ServiceRequest, Error>>,
    {
        /// Construct `HttpAuthentication` middleware for the HTTP "Basic" authentication scheme.
        ///
        /// # Example
        /// ```
        /// # use actix_web::Error;
        /// # use actix_web::dev::ServiceRequest;
        /// # use actix_web_httpauth::middleware::HttpAuthentication;
        /// # use actix_web_httpauth::extractors::basic::BasicAuth;
        /// // In this example validator returns immediately, but since it is required to return
        /// // anything that implements `IntoFuture` trait, it can be extended to query database or to
        /// // do something else in a async manner.
        /// async fn validator(
        ///     req: ServiceRequest,
        ///     credentials: BasicAuth,
        /// ) -> Result<ServiceRequest, Error> {
        ///     // All users are great and more than welcome!
        ///     Ok(req)
        /// }
        ///
        /// let middleware = HttpAuthentication::basic(validator);
        /// ```
        pub fn basic(process_fn: F) -> Self {
            Self::with_fn(process_fn)
        }
    }

    impl<F, O> HttpAuthentication<bearer::BearerAuth, F>
    where
        F: Fn(ServiceRequest, bearer::BearerAuth) -> O,
        O: Future<Output = Result<ServiceRequest, Error>>,
    {
        /// Construct `HttpAuthentication` middleware for the HTTP "Bearer" authentication scheme.
        ///
        /// # Example
        /// ```
        /// # use actix_web::Error;
        /// # use actix_web::dev::ServiceRequest;
        /// # use actix_web_httpauth::middleware::HttpAuthentication;
        /// # use actix_web_httpauth::extractors::bearer::{Config, BearerAuth};
        /// # use actix_web_httpauth::extractors::{AuthenticationError, AuthExtractorConfig};
        /// async fn validator(req: ServiceRequest, credentials: BearerAuth) -> Result<ServiceRequest, Error> {
        ///     if credentials.token() == "mF_9.B5f-4.1JqM" {
        ///         Ok(req)
        ///     } else {
        ///         let config = req.app_data::<Config>()
        ///             .map(|data| data.clone())
        ///             .unwrap_or_else(Default::default)
        ///             .scope("urn:example:channel=HBO&urn:example:rating=G,PG-13");
        ///
        ///         Err(AuthenticationError::from(config).into())
        ///     }
        /// }
        ///
        /// let middleware = HttpAuthentication::bearer(validator);
        /// ```
        pub fn bearer(process_fn: F) -> Self {
            Self::with_fn(process_fn)
        }
    }

    impl<S, B, T, F, O> Transform<S, ServiceRequest> for HttpAuthentication<T, F>
    where
        S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error> + 'static,
        S::Future: 'static,
        F: Fn(ServiceRequest, T) -> O + 'static,
        O: Future<Output = Result<ServiceRequest, Error>> + 'static,
        T: AuthExtractor + 'static,
        B: MessageBody + 'static,
    {
        type Response = ServiceResponse<EitherBody<B>>;
        type Error = Error;
        type Transform = AuthenticationMiddleware<S, F, T>;
        type InitError = ();
        type Future = future::Ready<Result<Self::Transform, Self::InitError>>;

        fn new_transform(&self, service: S) -> Self::Future {
            future::ok(AuthenticationMiddleware {
                service: Rc::new(service),
                process_fn: self.process_fn.clone(),
                _extractor: PhantomData,
            })
        }
    }

    #[doc(hidden)]
    pub struct AuthenticationMiddleware<S, F, T>
    where
        T: AuthExtractor,
    {
        service: Rc<S>,
        process_fn: Arc<F>,
        _extractor: PhantomData<T>,
    }

    impl<S, B, F, T, O> Service<ServiceRequest> for AuthenticationMiddleware<S, F, T>
    where
        S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error> + 'static,
        S::Future: 'static,
        F: Fn(ServiceRequest, T) -> O + 'static,
        O: Future<Output = Result<ServiceRequest, Error>> + 'static,
        T: AuthExtractor + 'static,
        B: MessageBody + 'static,
    {
        type Response = ServiceResponse<EitherBody<B>>;
        type Error = S::Error;
        type Future = LocalBoxFuture<'static, Result<Self::Response, Self::Error>>;

        actix_service::forward_ready!(service);

        fn call(&self, req: ServiceRequest) -> Self::Future {
            let process_fn = Arc::clone(&self.process_fn);

            let service = Rc::clone(&self.service);

            async move {
                let (req, credentials) = match Extract::<T>::new(req).await {
                    Ok(req) => req,
                    Err((err, req)) => {
                        return Ok(req.error_response(err).map_into_right_body());
                    }
                };

                // TODO: alter to remove ? operator; an error response is required for downstream
                // middleware to do their thing (eg. cors adding headers)
                let req = process_fn(req, credentials).await?;

                service.call(req).await.map(|res| res.map_into_left_body())
            }
            .boxed_local()
        }
    }

    struct Extract<T> {
        req: Option<ServiceRequest>,
        f: Option<LocalBoxFuture<'static, Result<T, Error>>>,
        _extractor: PhantomData<fn() -> T>,
    }

    impl<T> Extract<T> {
        pub fn new(req: ServiceRequest) -> Self {
            Extract {
                req: Some(req),
                f: None,
                _extractor: PhantomData,
            }
        }
    }

    impl<T> Future for Extract<T>
    where
        T: AuthExtractor,
        T::Future: 'static,
        T::Error: 'static,
    {
        type Output = Result<(ServiceRequest, T), (Error, ServiceRequest)>;

        fn poll(mut self: Pin<&mut Self>, ctx: &mut Context<'_>) -> Poll<Self::Output> {
            if self.f.is_none() {
                let req = self.req.as_ref().expect("Extract future was polled twice!");
                let f = T::from_service_request(req).map_err(Into::into);
                self.f = Some(f.boxed_local());
            }

            let f = self
                .f
                .as_mut()
                .expect("Extraction future should be initialized at this point");

            let credentials = ready!(f.as_mut().poll(ctx)).map_err(|err| {
                (
                    err,
                    // returning request allows a proper error response to be created
                    self.req.take().expect("Extract future was polled twice!"),
                )
            })?;

            let req = self.req.take().expect("Extract future was polled twice!");
            Poll::Ready(Ok((req, credentials)))
        }
    }

    #[cfg(test)]
    mod tests {
        use super::*;
        use crate::extractors::basic::BasicAuth;
        use crate::extractors::bearer::BearerAuth;
        use actix_service::{into_service, Service};
        use actix_web::error::ErrorForbidden;
        use actix_web::http::StatusCode;
        use actix_web::test::TestRequest;
        use actix_web::{error, web, App, HttpResponse};

        /// This is a test for https://github.com/actix/actix-extras/issues/10
        #[actix_web::test]
        async fn test_middleware_panic() {
            let middleware = AuthenticationMiddleware {
                service: Rc::new(into_service(|_: ServiceRequest| async move {
                    actix_web::rt::time::sleep(std::time::Duration::from_secs(1)).await;
                    Err::<ServiceResponse, _>(error::ErrorBadRequest("error"))
                })),
                process_fn: Arc::new(|req, _: BearerAuth| async { Ok(req) }),
                _extractor: PhantomData,
            };

            let req = TestRequest::get()
                .append_header(("Authorization", "Bearer 1"))
                .to_srv_request();

            let f = middleware.call(req).await;

            let _res = futures_util::future::lazy(|cx| middleware.poll_ready(cx)).await;

            assert!(f.is_err());
        }

        /// This is a test for https://github.com/actix/actix-extras/issues/10
        #[actix_web::test]
        async fn test_middleware_panic_several_orders() {
            let middleware = AuthenticationMiddleware {
                service: Rc::new(into_service(|_: ServiceRequest| async move {
                    actix_web::rt::time::sleep(std::time::Duration::from_secs(1)).await;
                    Err::<ServiceResponse, _>(error::ErrorBadRequest("error"))
                })),
                process_fn: Arc::new(|req, _: BearerAuth| async { Ok(req) }),
                _extractor: PhantomData,
            };

            let req = TestRequest::get()
                .append_header(("Authorization", "Bearer 1"))
                .to_srv_request();

            let f1 = middleware.call(req).await;

            let req = TestRequest::get()
                .append_header(("Authorization", "Bearer 1"))
                .to_srv_request();

            let f2 = middleware.call(req).await;

            let req = TestRequest::get()
                .append_header(("Authorization", "Bearer 1"))
                .to_srv_request();

            let f3 = middleware.call(req).await;

            let _res = futures_util::future::lazy(|cx| middleware.poll_ready(cx)).await;

            assert!(f1.is_err());
            assert!(f2.is_err());
            assert!(f3.is_err());
        }

        #[actix_web::test]
        async fn test_middleware_opt_extractor() {
            let middleware = AuthenticationMiddleware {
                service: Rc::new(into_service(|req: ServiceRequest| async move {
                    Ok::<ServiceResponse, _>(req.into_response(HttpResponse::Ok().finish()))
                })),
                process_fn: Arc::new(|req, auth: Option<BearerAuth>| {
                    assert!(auth.is_none());
                    async { Ok(req) }
                }),
                _extractor: PhantomData,
            };

            let req = TestRequest::get()
                .append_header(("Authorization996", "Bearer 1"))
                .to_srv_request();

            let f = middleware.call(req).await;

            let _res = futures_util::future::lazy(|cx| middleware.poll_ready(cx)).await;

            assert!(f.is_ok());
        }

        #[actix_web::test]
        async fn test_middleware_res_extractor() {
            let middleware = AuthenticationMiddleware {
                service: Rc::new(into_service(|req: ServiceRequest| async move {
                    Ok::<ServiceResponse, _>(req.into_response(HttpResponse::Ok().finish()))
                })),
                process_fn: Arc::new(
                    |req, auth: Result<BearerAuth, <BearerAuth as AuthExtractor>::Error>| {
                        assert!(auth.is_err());
                        async { Ok(req) }
                    },
                ),
                _extractor: PhantomData,
            };

            let req = TestRequest::get()
                .append_header(("Authorization", "BearerLOL"))
                .to_srv_request();

            let f = middleware.call(req).await;

            let _res = futures_util::future::lazy(|cx| middleware.poll_ready(cx)).await;

            assert!(f.is_ok());
        }

        #[actix_web::test]
        async fn test_middleware_works_with_app() {
            async fn validator(
                _req: ServiceRequest,
                _credentials: BasicAuth,
            ) -> Result<ServiceRequest, actix_web::Error> {
                Err(ErrorForbidden("You are not welcome!"))
            }
            let middleware = HttpAuthentication::basic(validator);

            let srv = actix_web::test::init_service(
                App::new()
                    .wrap(middleware)
                    .route("/", web::get().to(HttpResponse::Ok)),
            )
            .await;

            let req = actix_web::test::TestRequest::with_uri("/")
                .append_header(("Authorization", "Basic DontCare"))
                .to_request();

            let resp = srv.call(req).await.unwrap();
            assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);
        }

        #[actix_web::test]
        async fn test_middleware_works_with_scope() {
            async fn validator(
                _req: ServiceRequest,
                _credentials: BasicAuth,
            ) -> Result<ServiceRequest, actix_web::Error> {
                Err(ErrorForbidden("You are not welcome!"))
            }
            let middleware = actix_web::middleware::Compat::new(HttpAuthentication::basic(validator));

            let srv = actix_web::test::init_service(
                App::new().service(
                    web::scope("/")
                        .wrap(middleware)
                        .route("/", web::get().to(HttpResponse::Ok)),
                ),
            )
            .await;

            let req = actix_web::test::TestRequest::with_uri("/")
                .append_header(("Authorization", "Basic DontCare"))
                .to_request();

            let resp = srv.call(req).await.unwrap();
            assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);
        }
    }