From 22c776f46ea169a29d5a34572d71a966db25044b Mon Sep 17 00:00:00 2001
From: Nikolay Kim <fafhrd91@gmail.com>
Date: Fri, 13 Apr 2018 10:13:12 -0700
Subject: [PATCH] Fix StaticFiles does not support percent encoded paths #177

---
 CHANGES.md |  5 +++++
 src/fs.rs  | 17 ++++++++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/CHANGES.md b/CHANGES.md
index 60b6aaf97..bc1b68d88 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,6 +1,11 @@
 # Changes
 
 
+## 0.5.2 (2018-04-xx)
+
+* Fix StaticFiles does not support percent encoded paths #177
+
+
 ## 0.5.1 (2018-04-12)
 
 * Client connector provides stats, `ClientConnector::stats()`
diff --git a/src/fs.rs b/src/fs.rs
index acb3121d8..4dbff6f88 100644
--- a/src/fs.rs
+++ b/src/fs.rs
@@ -15,6 +15,7 @@ use bytes::{Bytes, BytesMut, BufMut};
 use futures::{Async, Poll, Future, Stream};
 use futures_cpupool::{CpuPool, CpuFuture};
 use mime_guess::get_mime_type;
+use percent_encoding::percent_decode;
 
 use header;
 use error::Error;
@@ -484,7 +485,10 @@ impl<S: 'static> Handler<S> for StaticFiles<S> {
         if !self.accessible {
             Ok(self.default.handle(req))
         } else {
-            let relpath = match req.match_info().get("tail").map(PathBuf::from_param) {
+            let relpath = match req.match_info().get("tail").map(
+                |tail| percent_decode(tail.as_bytes()).decode_utf8().unwrap())
+                .map(|tail| PathBuf::from_param(tail.as_ref()))
+            {
                 Some(Ok(path)) => path,
                 _ => return Ok(self.default.handle(req))
             };
@@ -671,4 +675,15 @@ mod tests {
         let loc = response.headers().get(header::LOCATION).unwrap().to_str().unwrap();
         assert_eq!(loc, "/test/Cargo.toml");
     }
+
+    #[test]
+    fn integration_percent_encoded() {
+        let mut srv = test::TestServer::with_factory(
+            || App::new()
+                .handler("test", StaticFiles::new(".").index_file("Cargo.toml")));
+
+        let request = srv.get().uri(srv.url("/test/%43argo.toml")).finish().unwrap();
+        let response = srv.execute(request.send()).unwrap();
+        assert_eq!(response.status(), StatusCode::OK);
+    }
 }