actix/actix-extras
1
0
Fork 0
mirror of https://github.com/actix/actix-extras.git synced 2024-11-27 09:12:57 +01:00
Code Issues Releases Wiki Activity

bump actix-web to 4.0.0-rc.1

Browse Source
This commit is contained in:
Rob Ede 2022-02-03 22:33:47 +00:00
parent 6abec48e29
commit 323d01fcca
No known key found for this signature in database
GPG Key ID: 97C636207D3EF933
27 changed files with 84 additions and 79 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
actix-cors/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.6.0-beta.8 - 2021-12-29
@ -8,7 +9,7 @@
## 0.6.0-beta.7 - 2021-12-18
- Update `actix-web` dependency to `4.0.0.beta-15`. [#216]
- Update `actix-web` dependency to `4.0.0-beta.15`. [#216]
[#216]: https://github.com/actix/actix-extras/pull/216

4
actix-cors/Cargo.toml
View File

@ -19,7 +19,7 @@ path = "src/lib.rs"
[dependencies]
actix-service = "2"
actix-utils = "3"
actix-web = { version = "4.0.0-beta.17", default-features = false }
actix-web = { version = "4.0.0-rc.1", default-features = false }
derive_more = "0.99.5"
futures-util = { version = "0.3.7", default-features = false }
@ -28,6 +28,6 @@ once_cell = "1"
smallvec = "1.6.1"
[dev-dependencies]
actix-rt = "2"
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros"] }
env_logger = "0.9"
regex = "1.4"

8
actix-cors/src/builder.rs
View File

@ -597,7 +597,7 @@ mod test {
.is_err());
}
#[actix_rt::test]
#[actix_web::test]
async fn restrictive_defaults() {
let cors = Cors::default()
.new_transform(test::ok_service())
@ -612,12 +612,12 @@ mod test {
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
}
#[actix_rt::test]
#[actix_web::test]
async fn allowed_header_try_from() {
let _cors = Cors::default().allowed_header("Content-Type");
}
#[actix_rt::test]
#[actix_web::test]
async fn allowed_header_try_into() {
struct ContentType;
@ -632,7 +632,7 @@ mod test {
let _cors = Cors::default().allowed_header(ContentType);
}
#[actix_rt::test]
#[actix_web::test]
async fn middleware_generic_over_body_type() {
let srv = fn_service(|req: ServiceRequest| async move {
Ok(req.into_response(HttpResponse::with_body(StatusCode::OK, body::None::new())))

4
actix-cors/src/inner.rs
View File

@ -218,7 +218,7 @@ mod test {
val.to_str().unwrap()
}
#[actix_rt::test]
#[actix_web::test]
async fn test_validate_not_allowed_origin() {
let cors = Cors::default()
.allowed_origin("https://www.example.com")
@ -236,7 +236,7 @@ mod test {
assert!(cors.inner.validate_allowed_headers(req.head()).is_err());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_preflight() {
let mut cors = Cors::default()
.allow_any_origin()

2
actix-cors/src/middleware.rs
View File

@ -195,7 +195,7 @@ mod tests {
use super::*;
use crate::Cors;
#[actix_rt::test]
#[actix_web::test]
async fn test_options_no_origin() {
// Tests case where allowed_origins is All but there are validate functions to run incase.
// In this case, origins are only allowed when the DNT header is sent.

22
actix-cors/tests/tests.rs
View File

@ -17,7 +17,7 @@ fn val_as_str(val: &HeaderValue) -> &str {
val.to_str().unwrap()
}
#[actix_rt::test]
#[actix_web::test]
#[should_panic]
async fn test_wildcard_origin() {
Cors::default()
@ -27,7 +27,7 @@ async fn test_wildcard_origin() {
.unwrap();
}
#[actix_rt::test]
#[actix_web::test]
async fn test_not_allowed_origin_fn() {
let cors = Cors::default()
.allowed_origin("https://www.example.com")
@ -73,7 +73,7 @@ async fn test_not_allowed_origin_fn() {
}
}
#[actix_rt::test]
#[actix_web::test]
async fn test_allowed_origin_fn() {
let cors = Cors::default()
.allowed_origin("https://www.example.com")
@ -118,7 +118,7 @@ async fn test_allowed_origin_fn() {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_allowed_origin_fn_with_environment() {
let regex = Regex::new("https:.+\\.unknown\\.com").unwrap();
@ -165,7 +165,7 @@ async fn test_allowed_origin_fn_with_environment() {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_multiple_origins_preflight() {
let cors = Cors::default()
.allowed_origin("https://example.com")
@ -204,7 +204,7 @@ async fn test_multiple_origins_preflight() {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_multiple_origins() {
let cors = Cors::default()
.allowed_origin("https://example.com")
@ -239,7 +239,7 @@ async fn test_multiple_origins() {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_response() {
let exposed_headers = vec![header::AUTHORIZATION, header::ACCEPT];
let cors = Cors::default()
@ -340,7 +340,7 @@ async fn test_response() {
assert_eq!(Some("https://www.example.com"), origins_str);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_validate_origin() {
let cors = Cors::default()
.allowed_origin("https://www.example.com")
@ -356,7 +356,7 @@ async fn test_validate_origin() {
assert_eq!(resp.status(), StatusCode::OK);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_no_origin_response() {
let cors = Cors::permissive()
.disable_preflight()
@ -384,7 +384,7 @@ async fn test_no_origin_response() {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn validate_origin_allows_all_origins() {
let cors = Cors::permissive()
.new_transform(test::ok_service())
@ -399,7 +399,7 @@ async fn validate_origin_allows_all_origins() {
assert_eq!(resp.status(), StatusCode::OK);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_allow_any_origin_any_method_any_header() {
let cors = Cors::default()
.allow_any_origin()

1
actix-identity/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.4.0-beta.8 - 2022-01-21

10
actix-identity/Cargo.toml
View File

@ -16,13 +16,13 @@ path = "src/lib.rs"
[dependencies]
actix-service = "2"
actix-utils = "3"
actix-web = { version = "4.0.0-beta.21", default-features = false, features = ["cookies", "secure-cookies"] }
actix-web = { version = "4.0.0-rc.1", default-features = false, features = ["cookies", "secure-cookies"] }
futures-util = { version = "0.3.7", default-features = false }
serde = "1.0"
serde_json = "1.0"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
time = "0.3"
[dev-dependencies]
actix-http = "3.0.0-beta.15"
actix-rt = "2"
actix-http = "3.0.0-rc.1"
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros", "cookies", "secure-cookies"] }

28
actix-identity/src/cookie.rs
View File

@ -455,7 +455,7 @@ mod tests {
}
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_flow() {
let srv = test::init_service(
App::new()
@ -514,7 +514,7 @@ mod tests {
assert!(resp.headers().contains_key(header::SET_COOKIE))
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_max_age_time() {
let duration = Duration::days(1);
@ -542,7 +542,7 @@ mod tests {
assert_eq!(duration, c.max_age().unwrap());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_http_only_same_site() {
let srv = test::init_service(
App::new()
@ -610,7 +610,7 @@ mod tests {
assert!(cookies.get(COOKIE_NAME).is_none());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_max_age() {
let seconds = 60;
let srv = test::init_service(
@ -636,7 +636,7 @@ mod tests {
assert_eq!(Duration::seconds(seconds as i64), c.max_age().unwrap());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_legacy_cookie_is_set() {
let srv = create_identity_server(|c| c).await;
let mut resp = test::call_service(&srv, TestRequest::with_uri("/").to_request()).await;
@ -644,7 +644,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_legacy_cookie_works() {
let srv = create_identity_server(|c| c).await;
let cookie = legacy_login_cookie(COOKIE_LOGIN);
@ -659,7 +659,7 @@ mod tests {
assert_logged_in(resp, Some(COOKIE_LOGIN)).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_legacy_cookie_rejected_if_visit_timestamp_needed() {
let srv = create_identity_server(|c| c.visit_deadline(Duration::days(90))).await;
let cookie = legacy_login_cookie(COOKIE_LOGIN);
@ -679,7 +679,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_legacy_cookie_rejected_if_login_timestamp_needed() {
let srv = create_identity_server(|c| c.login_deadline(Duration::days(90))).await;
let cookie = legacy_login_cookie(COOKIE_LOGIN);
@ -699,7 +699,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_rejected_if_login_timestamp_needed() {
let srv = create_identity_server(|c| c.login_deadline(Duration::days(90))).await;
let cookie = login_cookie(COOKIE_LOGIN, None, Some(SystemTime::now()));
@ -719,7 +719,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_rejected_if_visit_timestamp_needed() {
let srv = create_identity_server(|c| c.visit_deadline(Duration::days(90))).await;
let cookie = login_cookie(COOKIE_LOGIN, Some(SystemTime::now()), None);
@ -739,7 +739,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_rejected_if_login_timestamp_too_old() {
let srv = create_identity_server(|c| c.login_deadline(Duration::days(90))).await;
let cookie = login_cookie(
@ -763,7 +763,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_rejected_if_visit_timestamp_too_old() {
let srv = create_identity_server(|c| c.visit_deadline(Duration::days(90))).await;
let cookie = login_cookie(
@ -787,7 +787,7 @@ mod tests {
assert_logged_in(resp, None).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_not_updated_on_login_deadline() {
let srv = create_identity_server(|c| c.login_deadline(Duration::days(90))).await;
let cookie = login_cookie(COOKIE_LOGIN, Some(SystemTime::now()), None);
@ -802,7 +802,7 @@ mod tests {
assert_logged_in(resp, Some(COOKIE_LOGIN)).await;
}
#[actix_rt::test]
#[actix_web::test]
async fn test_identity_cookie_updated_on_visit_deadline() {
let srv = create_identity_server(|c| {
c.visit_deadline(Duration::days(90))

8
actix-identity/src/middleware.rs
View File

@ -127,7 +127,7 @@ mod tests {
use super::*;
#[actix_rt::test]
#[actix_web::test]
async fn test_borrowed_mut_error() {
use actix_utils::future::{ok, Ready};
use futures_util::future::lazy;
@ -154,7 +154,7 @@ mod tests {
let srv = crate::middleware::IdentityServiceMiddleware {
backend: Rc::new(Ident),
service: Rc::new(into_service(|_: dev::ServiceRequest| async move {
actix_rt::time::sleep(Duration::from_secs(100)).await;
actix_web::rt::time::sleep(Duration::from_secs(100)).await;
Err::<dev::ServiceResponse, _>(error::ErrorBadRequest("error"))
})),
};
@ -162,11 +162,11 @@ mod tests {
let srv2 = srv.clone();
let req = test::TestRequest::default().to_srv_request();
actix_rt::spawn(async move {
actix_web::rt::spawn(async move {
let _ = srv2.call(req).await;
});
actix_rt::time::sleep(Duration::from_millis(50)).await;
actix_web::rt::time::sleep(Duration::from_millis(50)).await;
let _ = lazy(|cx| srv.poll_ready(cx)).await;
}

1
actix-protobuf/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.7.0-beta.5 - 2022-02-03

4
actix-protobuf/Cargo.toml
View File

@ -18,11 +18,11 @@ name = "actix_protobuf"
path = "src/lib.rs"
[dependencies]
actix-rt = "2"
actix-web = { version = "4.0.0-beta.17", default_features = false }
actix-web = { version = "4.0.0-rc.1", default_features = false }
derive_more = "0.99.5"
futures-util = { version = "0.3.7", default-features = false }
prost = { version = "0.9", default_features = false }
[dev-dependencies]
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros"] }
prost = { version = "0.9", default_features = false, features = ["prost-derive"] }

4
actix-protobuf/examples/prost-example/Cargo.toml
View File

@ -8,8 +8,8 @@ authors = [
]
[dependencies]
actix-web = "4.0.0-beta.17"
actix-web = "4.0.0-rc.2"
actix-protobuf = { path = "../../" }
env_logger = "0.8"
prost = {version = "0.8", default_features = false, features = ["prost-derive"] }
prost = { version = "0.8", default_features = false, features = ["prost-derive"] }

6
actix-protobuf/src/lib.rs
View File

@ -294,19 +294,19 @@ mod tests {
pub name: String,
}
#[actix_rt::test]
#[actix_web::test]
async fn test_protobuf() {
let protobuf = ProtoBuf(MyObject {
number: 9,
name: "test".to_owned(),
});
let req = TestRequest::default().to_http_request();
let resp = protobuf.respond_to(&req).await.unwrap();
let resp = protobuf.respond_to(&req);
let ct = resp.headers().get(header::CONTENT_TYPE).unwrap();
assert_eq!(ct, "application/protobuf");
}
#[actix_rt::test]
#[actix_web::test]
async fn test_protobuf_message() {
let (req, mut pl) = TestRequest::default().to_http_parts();
let protobuf = ProtoBufMessage::<MyObject>::new(&req, &mut pl).await;

1
actix-redis/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.10.0-beta.5 - 2021-12-29

7
actix-redis/Cargo.toml
View File

@ -30,7 +30,6 @@ web = [
[dependencies]
actix = { version = "0.12.0", default-features = false }
actix-rt = { version = "2.1", default-features = false }
actix-service = "2.0.0"
actix-tls = { version = "3.0.0-rc.2", default-features = false, features = ["connect"] }
@ -45,15 +44,15 @@ tokio = { version = "1.13.1", features = ["sync"] }
tokio-util = "0.6.1"
# actix-session
actix-web = { version = "4.0.0-beta.18", default_features = false, optional = true }
actix-web = { version = "4.0.0-rc.1", default_features = false, optional = true }
actix-session = { version = "0.5.0-beta.7", optional = true }
rand = { version = "0.8.0", optional = true }
serde = { version = "1.0.101", optional = true }
serde_json = { version = "1.0.40", optional = true }
[dev-dependencies]
actix-test = "0.1.0-beta.10"
actix-rt = "2.1"
actix-test = "0.1.0-beta.12"
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros"] }
env_logger = "0.9"
serde = { version = "1.0.101", features = ["derive"] }

2
actix-redis/examples/authentication.rs
View File

@ -68,7 +68,7 @@ async fn secret(session: Session) -> Result<impl Responder, Error> {
Ok("secret revealed")
}
#[actix_rt::main]
#[actix_web::main]
async fn main() -> std::io::Result<()> {
std::env::set_var("RUST_LOG", "actix_web=info,actix_redis=info");
env_logger::init();

2
actix-redis/examples/basic.rs
View File

@ -17,7 +17,7 @@ async fn index(req: HttpRequest, session: Session) -> Result<impl Responder, Err
Ok("Welcome!")
}
#[actix_rt::main]
#[actix_web::main]
async fn main() -> std::io::Result<()> {
std::env::set_var("RUST_LOG", "actix_web=info,actix_redis=info");
env_logger::init();

2
actix-redis/src/redis.rs
View File

@ -2,9 +2,9 @@ use std::collections::VecDeque;
use std::io;
use actix::prelude::*;
use actix_rt::net::TcpStream;
use actix_service::boxed::{self, BoxService};
use actix_tls::connect::{ConnectError, ConnectInfo, Connection, ConnectorService};
use actix_web::rt::net::TcpStream;
use backoff::backoff::Backoff;
use backoff::ExponentialBackoff;
use log::{error, info, warn};

4
actix-redis/src/session.rs
View File

@ -447,7 +447,7 @@ mod test {
Ok(HttpResponse::Ok().body(body))
}
#[actix_rt::test]
#[actix_web::test]
async fn test_session_workflow() {
// Step 1: GET index
// - set-cookie actix-session should NOT be in response (session data is empty)
@ -653,7 +653,7 @@ mod test {
);
}
#[actix_rt::test]
#[actix_web::test]
async fn test_max_age_session_only() {
//
// Test that removing max_age results in a session-only cookie

4
actix-redis/tests/test_redis.rs
View File

@ -3,7 +3,7 @@ extern crate redis_async;
use actix_redis::{Command, Error, RedisActor, RespValue};
#[actix_rt::test]
#[actix_web::test]
async fn test_error_connect() {
let addr = RedisActor::start("localhost:54000");
let _addr2 = addr.clone();
@ -15,7 +15,7 @@ async fn test_error_connect() {
}
}
#[actix_rt::test]
#[actix_web::test]
async fn test_redis() {
env_logger::init();

1
actix-session/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.5.0-beta.7 - 2021-12-29

4
actix-session/Cargo.toml
View File

@ -20,7 +20,7 @@ cookie-session = ["actix-web/secure-cookies"]
[dependencies]
actix-service = "2"
actix-utils = "3"
actix-web = { version = "4.0.0-beta.18", default_features = false, features = ["cookies"] }
actix-web = { version = "4.0.0-rc.1", default_features = false, features = ["cookies"] }
derive_more = "0.99.5"
futures-util = { version = "0.3.7", default-features = false }
@ -30,4 +30,4 @@ serde_json = "1.0"
time = "0.3"
[dev-dependencies]
actix-rt = "2"
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros", "cookies"] }

14
actix-session/src/cookie.rs
View File

@ -393,7 +393,7 @@ mod tests {
use actix_web::web::Bytes;
use actix_web::{test, web, App};
#[actix_rt::test]
#[actix_web::test]
async fn cookie_session() {
let app = test::init_service(
App::new()
@ -413,7 +413,7 @@ mod tests {
.any(|c| c.name() == "actix-session"));
}
#[actix_rt::test]
#[actix_web::test]
async fn private_cookie() {
let app = test::init_service(
App::new()
@ -433,7 +433,7 @@ mod tests {
.any(|c| c.name() == "actix-session"));
}
#[actix_rt::test]
#[actix_web::test]
async fn lazy_cookie() {
let app = test::init_service(
App::new()
@ -459,7 +459,7 @@ mod tests {
.any(|c| c.name() == "actix-session"));
}
#[actix_rt::test]
#[actix_web::test]
async fn cookie_session_extractor() {
let app = test::init_service(
App::new()
@ -479,7 +479,7 @@ mod tests {
.any(|c| c.name() == "actix-session"));
}
#[actix_rt::test]
#[actix_web::test]
async fn basics() {
let app = test::init_service(
App::new()
@ -520,7 +520,7 @@ mod tests {
assert_eq!(body, Bytes::from_static(b"counter: 100"));
}
#[actix_rt::test]
#[actix_web::test]
async fn prolong_expiration() {
let app = test::init_service(
App::new()
@ -545,7 +545,7 @@ mod tests {
.datetime()
.expect("Expiration is a datetime");
actix_rt::time::sleep(std::time::Duration::from_secs(1)).await;
actix_web::rt::time::sleep(std::time::Duration::from_secs(1)).await;
let request = test::TestRequest::with_uri("/test/").to_request();
let response = app.call(request).await.unwrap();

1
actix-web-httpauth/CHANGES.md
View File

@ -1,6 +1,7 @@
# Changes
## Unreleased - 2021-xx-xx
- Update `actix-web` dependency to `4.0.0-rc.1`.
## 0.6.0-beta.7 - 2021-12-29

4
actix-web-httpauth/Cargo.toml
View File

@ -20,7 +20,7 @@ path = "src/lib.rs"
[dependencies]
actix-service = "2"
actix-utils = "3"
actix-web = { version = "4.0.0-beta.17", default_features = false }
actix-web = { version = "4.0.0-rc.1", default_features = false }
base64 = "0.13"
futures-util = { version = "0.3.7", default-features = false }
@ -29,4 +29,4 @@ pin-project-lite = "0.2.7"
[dev-dependencies]
actix-cors = "0.6.0-beta.8"
actix-rt = "2"
actix-web = { version = "4.0.0-rc.2", default_features = false, features = ["macros"] }

12
actix-web-httpauth/src/middleware.rs
View File

@ -248,11 +248,11 @@ mod tests {
use actix_web::{error, HttpResponse};
/// This is a test for https://github.com/actix/actix-extras/issues/10
#[actix_rt::test]
#[actix_web::test]
async fn test_middleware_panic() {
let middleware = AuthenticationMiddleware {
service: Rc::new(into_service(|_: ServiceRequest| async move {
actix_rt::time::sleep(std::time::Duration::from_secs(1)).await;
actix_web::rt::time::sleep(std::time::Duration::from_secs(1)).await;
Err::<ServiceResponse, _>(error::ErrorBadRequest("error"))
})),
process_fn: Arc::new(|req, _: BearerAuth| async { Ok(req) }),
@ -271,11 +271,11 @@ mod tests {
}
/// This is a test for https://github.com/actix/actix-extras/issues/10
#[actix_rt::test]
#[actix_web::test]
async fn test_middleware_panic_several_orders() {
let middleware = AuthenticationMiddleware {
service: Rc::new(into_service(|_: ServiceRequest| async move {
actix_rt::time::sleep(std::time::Duration::from_secs(1)).await;
actix_web::rt::time::sleep(std::time::Duration::from_secs(1)).await;
Err::<ServiceResponse, _>(error::ErrorBadRequest("error"))
})),
process_fn: Arc::new(|req, _: BearerAuth| async { Ok(req) }),
@ -307,7 +307,7 @@ mod tests {
assert!(f3.is_err());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_middleware_opt_extractor() {
let middleware = AuthenticationMiddleware {
service: Rc::new(into_service(|req: ServiceRequest| async move {
@ -331,7 +331,7 @@ mod tests {
assert!(f.is_ok());
}
#[actix_rt::test]
#[actix_web::test]
async fn test_middleware_res_extractor() {
let middleware = AuthenticationMiddleware {
service: Rc::new(into_service(|req: ServiceRequest| async move {