clippy

actix-identity/src/middleware.rs

@@ -162,14 +162,12 @@ fn enforce_policies(req: &ServiceRequest, configuration: &Configuration) {
         ) {
             identity.logout();
             return;
-        } else {
+        } else if let Err(err) = identity.set_last_visited_at() {
-            if let Err(err) = identity.set_last_visited_at() {
+            tracing::warn!(
-                tracing::warn!(
+                error.display = %err,
-                    error.display = %err,
+                error.debug = ?err,
-                    error.debug = ?err,
+                "Failed to set the last visited timestamp on `Identity` for an incoming request."
-                    "Failed to set the last visited timestamp on `Identity` for an incoming request."
+            );
-                );
-            }
         }
     }
 }

actix-identity/tests/integration/test_app.rs

@@ -103,14 +103,14 @@ impl TestApp {
     }
 }
 
-#[derive(Serialize, Deserialize, Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct EndpointResponse {
     pub user_id: Option<String>,
     pub counter: i32,
     pub session_status: String,
 }
 
-#[derive(Serialize, Deserialize, Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
 struct LoginRequest {
     user_id: String,
 }

actix-protobuf/src/lib.rs

@@ -287,7 +287,7 @@ mod tests {
         }
     }
 
-    #[derive(Clone, PartialEq, Message)]
+    #[derive(Clone, PartialEq, Eq, Message)]
     pub struct MyObject {
         #[prost(int32, tag = "1")]
         pub number: i32,

actix-session/src/lib.rs

@@ -648,7 +648,7 @@ pub mod test_helpers {
             );
         }
 
-        #[derive(Serialize, Deserialize, Debug, PartialEq)]
+        #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
         pub struct IndexResponse {
             user_id: Option<String>,
             counter: i32,