Fix long client urls #129

CHANGES.md

@@ -2,6 +2,8 @@
 
 ## 0.4.11 
 
+* Fix long client urls #129
+
 * Fix client connection pooling
 
 * Use more ergonomic `actix_web::Error` instead of `http::Error` for `HttpResponseBuilder::body()`

src/client/writer.rs

@@ -98,26 +98,26 @@ impl HttpClientWriter {
         self.flags.insert(Flags::STARTED);
         self.encoder = content_encoder(self.buffer.clone(), msg);
 
-        // render message
-        {
-            let mut buffer = self.buffer.get_mut();
-            if let Body::Binary(ref bytes) = *msg.body() {
-                buffer.reserve(256 + msg.headers().len() * AVERAGE_HEADER_SIZE + bytes.len());
-            } else {
-                buffer.reserve(256 + msg.headers().len() * AVERAGE_HEADER_SIZE);
-            }
-
         if msg.upgrade() {
             self.flags.insert(Flags::UPGRADE);
         }
 
+        // render message
+        {
             // status line
-            let _ = write!(buffer, "{} {} {:?}\r\n",
+            write!(self.buffer, "{} {} {:?}\r\n",
                    msg.method(),
                    msg.uri().path_and_query().map(|u| u.as_str()).unwrap_or("/"),
-                           msg.version());
+                   msg.version())?;
 
             // write headers
+            let mut buffer = self.buffer.get_mut();
+            if let Body::Binary(ref bytes) = *msg.body() {
+                buffer.reserve(msg.headers().len() * AVERAGE_HEADER_SIZE + bytes.len());
+            } else {
+                buffer.reserve(msg.headers().len() * AVERAGE_HEADER_SIZE);
+            }
+
             for (key, value) in msg.headers() {
                 let v = value.as_ref();
                 let k = key.as_str().as_bytes();

src/server/shared.rs

@@ -1,4 +1,4 @@
-use std::mem;
+use std::{io, mem};
 use std::cell::RefCell;
 use std::rc::Rc;
 use std::collections::VecDeque;
@@ -138,3 +138,13 @@ impl Clone for SharedBytes {
         SharedBytes(self.0.clone(), self.1.clone())
     }
 }
+
+impl io::Write for SharedBytes {
+    fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
+        self.extend_from_slice(buf);
+        Ok(buf.len())
+    }
+    fn flush(&mut self) -> io::Result<()> {
+        Ok(())
+    }
+}