From d23e48b4eeee60b5debae9e8af0391021d22f35c Mon Sep 17 00:00:00 2001 From: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com> Date: Mon, 19 Dec 2022 10:56:18 +0100 Subject: [PATCH] Clippy lints --- src/root_span_builder.rs | 14 +++++++------- src/root_span_macro.rs | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/root_span_builder.rs b/src/root_span_builder.rs index 96799b3c4..64b3a1d32 100644 --- a/src/root_span_builder.rs +++ b/src/root_span_builder.rs @@ -49,8 +49,8 @@ impl RootSpanBuilder for DefaultRootSpanBuilder { handle_error(span, response.status(), error.as_response_error()); } else { let code: i32 = response.response().status().as_u16().into(); - span.record("http.status_code", &code); - span.record("otel.status_code", &"OK"); + span.record("http.status_code", code); + span.record("otel.status_code", "OK"); } } Err(error) => { @@ -63,17 +63,17 @@ impl RootSpanBuilder for DefaultRootSpanBuilder { fn handle_error(span: Span, status_code: StatusCode, response_error: &dyn ResponseError) { // pre-formatting errors is a workaround for https://github.com/tokio-rs/tracing/issues/1565 - let display = format!("{}", response_error); - let debug = format!("{:?}", response_error); + let display = format!("{response_error}"); + let debug = format!("{response_error:?}"); span.record("exception.message", &tracing::field::display(display)); span.record("exception.details", &tracing::field::display(debug)); let code: i32 = status_code.as_u16().into(); - span.record("http.status_code", &code); + span.record("http.status_code", code); if status_code.is_client_error() { - span.record("otel.status_code", &"OK"); + span.record("otel.status_code", "OK"); } else { - span.record("otel.status_code", &"ERROR"); + span.record("otel.status_code", "ERROR"); } } diff --git a/src/root_span_macro.rs b/src/root_span_macro.rs index 17735bf29..95aee3929 100644 --- a/src/root_span_macro.rs +++ b/src/root_span_macro.rs @@ -192,7 +192,7 @@ pub mod private { Version::HTTP_11 => "1.1".into(), Version::HTTP_2 => "2.0".into(), Version::HTTP_3 => "3.0".into(), - other => format!("{:?}", other).into(), + other => format!("{other:?}").into(), } }