remove ClonableService

actix-utils/CHANGES.md

@@ -1,5 +1,12 @@
 # Changes
 
+## [0.4.5] - 2019-07-19
+
+### Removed
+
+* Deprecated `CloneableService` as it is not safe
+
+
 ## [0.4.4] - 2019-07-17
 
 ### Changed

actix-utils/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "actix-utils"
-version = "0.4.4"
+version = "0.4.5"
 authors = ["Nikolay Kim <fafhrd91@gmail.com>"]
 description = "Actix utils - various actix net related services"
 keywords = ["network", "framework", "async", "futures"]

actix-utils/src/cloneable.rs

@@ -1,55 +0,0 @@
-#![allow(deprecated)]
-use std::marker::PhantomData;
-use std::rc::Rc;
-
-use actix_service::Service;
-use futures::Poll;
-
-use super::cell::Cell;
-
-#[doc(hidden)]
-#[deprecated(since = "0.4.3", note = "support will be removed in actix-utils 0.4.5")]
-/// Service that allows to turn non-clone service to a service with `Clone` impl
-pub struct CloneableService<T> {
-    service: Cell<T>,
-    _t: PhantomData<Rc<()>>,
-}
-
-impl<T> CloneableService<T> {
-    pub fn new(service: T) -> Self
-    where
-        T: Service,
-    {
-        Self {
-            service: Cell::new(service),
-            _t: PhantomData,
-        }
-    }
-}
-
-impl<T> Clone for CloneableService<T> {
-    fn clone(&self) -> Self {
-        Self {
-            service: self.service.clone(),
-            _t: PhantomData,
-        }
-    }
-}
-
-impl<T> Service for CloneableService<T>
-where
-    T: Service,
-{
-    type Request = T::Request;
-    type Response = T::Response;
-    type Error = T::Error;
-    type Future = T::Future;
-
-    fn poll_ready(&mut self) -> Poll<(), Self::Error> {
-        self.service.get_mut().poll_ready()
-    }
-
-    fn call(&mut self, req: T::Request) -> Self::Future {
-        self.service.get_mut().call(req)
-    }
-}

actix-utils/src/lib.rs

@@ -1,6 +1,6 @@
 //! Actix utils - various helper services
+
 mod cell;
-pub mod cloneable;
 pub mod counter;
 pub mod either;
 pub mod framed;