service trait takes shared self reference (#247)

actix-tls/src/accept/nativetls.rs

@@ -79,7 +79,7 @@ where
     type Error = Error;
     type Future = LocalBoxFuture<'static, Result<TlsStream<T>, Error>>;
 
-    fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
+    fn poll_ready(&self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
         if self.conns.available(cx) {
             Poll::Ready(Ok(()))
         } else {
@@ -87,7 +87,7 @@ where
         }
     }
 
-    fn call(&mut self, io: T) -> Self::Future {
+    fn call(&self, io: T) -> Self::Future {
         let guard = self.conns.get();
         let this = self.clone();
         Box::pin(async move {

actix-tls/src/accept/openssl.rs

@@ -75,7 +75,7 @@ where
     type Error = SslError;
     type Future = AcceptorServiceResponse<T>;
 
-    fn poll_ready(&mut self, ctx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
+    fn poll_ready(&self, ctx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
         if self.conns.available(ctx) {
             Poll::Ready(Ok(()))
         } else {
@@ -83,7 +83,7 @@ where
         }
     }
 
-    fn call(&mut self, io: T) -> Self::Future {
+    fn call(&self, io: T) -> Self::Future {
         let ssl_ctx = self.acceptor.context();
         let ssl = Ssl::new(ssl_ctx).expect("Provided SSL acceptor was invalid.");
         AcceptorServiceResponse {

actix-tls/src/accept/rustls.rs

@@ -80,7 +80,7 @@ where
     type Error = io::Error;
     type Future = AcceptorServiceFut<T>;
 
-    fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
+    fn poll_ready(&self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
         if self.conns.available(cx) {
             Poll::Ready(Ok(()))
         } else {
@@ -88,7 +88,7 @@ where
         }
     }
 
-    fn call(&mut self, req: T) -> Self::Future {
+    fn call(&self, req: T) -> Self::Future {
         AcceptorServiceFut {
             _guard: self.conns.get(),
             fut: self.acceptor.accept(req),

actix-tls/src/connect/connector.rs

@@ -51,7 +51,7 @@ impl<T: Address> Service<Connect<T>> for TcpConnector {
 
     actix_service::always_ready!();
 
-    fn call(&mut self, req: Connect<T>) -> Self::Future {
+    fn call(&self, req: Connect<T>) -> Self::Future {
         let port = req.port();
         let Connect { req, addr, .. } = req;
 

actix-tls/src/connect/resolve.rs

@@ -146,7 +146,7 @@ impl<T: Address> Service<Connect<T>> for Resolver {
 
     actix_service::always_ready!();
 
-    fn call(&mut self, req: Connect<T>) -> Self::Future {
+    fn call(&self, req: Connect<T>) -> Self::Future {
         if !req.addr.is_none() {
             ResolverFuture::Connected(Some(req))
         } else if let Ok(ip) = req.host().parse() {

actix-tls/src/connect/service.rs

@@ -80,7 +80,7 @@ impl<T: Address> Service<Connect<T>> for ConnectService {
 
     actix_service::always_ready!();
 
-    fn call(&mut self, req: Connect<T>) -> Self::Future {
+    fn call(&self, req: Connect<T>) -> Self::Future {
         ConnectServiceResponse {
             fut: ConnectFuture::Resolve(self.resolver.call(req)),
             tcp: self.tcp,
@@ -149,7 +149,7 @@ impl<T: Address> Service<Connect<T>> for TcpConnectService {
 
     actix_service::always_ready!();
 
-    fn call(&mut self, req: Connect<T>) -> Self::Future {
+    fn call(&self, req: Connect<T>) -> Self::Future {
         TcpConnectServiceResponse {
             fut: ConnectFuture::Resolve(self.resolver.call(req)),
             tcp: self.tcp,

actix-tls/src/connect/ssl/openssl.rs

@@ -84,7 +84,7 @@ where
 
     actix_service::always_ready!();
 
-    fn call(&mut self, stream: Connection<T, U>) -> Self::Future {
+    fn call(&self, stream: Connection<T, U>) -> Self::Future {
         trace!("SSL Handshake start for: {:?}", stream.host());
         let (io, stream) = stream.replace(());
         let host = stream.host();
@@ -202,7 +202,7 @@ impl<T: Address + 'static> Service<Connect<T>> for OpensslConnectService {
 
     actix_service::always_ready!();
 
-    fn call(&mut self, req: Connect<T>) -> Self::Future {
+    fn call(&self, req: Connect<T>) -> Self::Future {
         OpensslConnectServiceResponse {
             fut1: Some(self.tcp.call(req)),
             fut2: None,

actix-tls/src/connect/ssl/rustls.rs

@@ -84,7 +84,7 @@ where
 
     actix_service::always_ready!();
 
-    fn call(&mut self, stream: Connection<T, U>) -> Self::Future {
+    fn call(&self, stream: Connection<T, U>) -> Self::Future {
         trace!("SSL Handshake start for: {:?}", stream.host());
         let (io, stream) = stream.replace(());
         let host = DNSNameRef::try_from_ascii_str(stream.host())

actix-tls/tests/test_connect.rs

@@ -22,7 +22,7 @@ async fn test_string() {
         })
     });
 
-    let mut conn = actix_connect::default_connector();
+    let conn = actix_connect::default_connector();
     let addr = format!("localhost:{}", srv.port());
     let con = conn.call(addr.into()).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
@@ -39,7 +39,7 @@ async fn test_rustls_string() {
         })
     });
 
-    let mut conn = actix_connect::default_connector();
+    let conn = actix_connect::default_connector();
     let addr = format!("localhost:{}", srv.port());
     let con = conn.call(addr.into()).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
@@ -55,13 +55,14 @@ async fn test_static_str() {
         })
     });
 
-    let mut conn = actix_connect::default_connector();
+    let conn = actix_connect::default_connector();
 
     let con = conn.call(Connect::with("10", srv.addr())).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
 
     let connect = Connect::new(srv.host().to_owned());
-    let mut conn = actix_connect::default_connector();
+
+    let conn = actix_connect::default_connector();
     let con = conn.call(connect).await;
     assert!(con.is_err());
 }
@@ -78,7 +79,7 @@ async fn test_new_service() {
 
     let factory = actix_connect::default_connector_factory();
 
-    let mut conn = factory.new_service(()).await.unwrap();
+    let conn = factory.new_service(()).await.unwrap();
     let con = conn.call(Connect::with("10", srv.addr())).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
 }
@@ -126,7 +127,7 @@ async fn test_custom_resolver() {
 
     let factory = actix_connect::new_connector_factory(resolver);
 
-    let mut conn = factory.new_service(()).await.unwrap();
+    let conn = factory.new_service(()).await.unwrap();
     let con = conn.call(Connect::with("10", srv.addr())).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
 }
@@ -144,7 +145,7 @@ async fn test_openssl_uri() {
         })
     });
 
-    let mut conn = actix_connect::default_connector();
+    let conn = actix_connect::default_connector();
     let addr = http::Uri::try_from(format!("https://localhost:{}", srv.port())).unwrap();
     let con = conn.call(addr.into()).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());
@@ -163,7 +164,7 @@ async fn test_rustls_uri() {
         })
     });
 
-    let mut conn = actix_connect::default_connector();
+    let conn = actix_connect::default_connector();
     let addr = http::Uri::try_from(format!("https://localhost:{}", srv.port())).unwrap();
     let con = conn.call(addr.into()).await.unwrap();
     assert_eq!(con.peer_addr().unwrap(), srv.addr());