From a0fe2a9b2e48a30aeca50f5756acbf0219548603 Mon Sep 17 00:00:00 2001 From: Rob Ede Date: Fri, 16 Jul 2021 21:46:32 +0100 Subject: [PATCH] clippy --- actix-router/src/url.rs | 2 +- actix-rt/tests/tests.rs | 2 +- actix-server/src/worker.rs | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/actix-router/src/url.rs b/actix-router/src/url.rs index 130ac76f..f84b1778 100644 --- a/actix-router/src/url.rs +++ b/actix-router/src/url.rs @@ -211,7 +211,7 @@ mod tests { } fn percent_encode(data: &[u8]) -> String { - data.into_iter().map(|c| format!("%{:02X}", c)).collect() + data.iter().map(|c| format!("%{:02X}", c)).collect() } #[test] diff --git a/actix-rt/tests/tests.rs b/actix-rt/tests/tests.rs index 86fba96d..839b1fbc 100644 --- a/actix-rt/tests/tests.rs +++ b/actix-rt/tests/tests.rs @@ -286,7 +286,7 @@ fn new_arbiter_with_tokio() { arb.join().unwrap(); - assert_eq!(false, counter.load(Ordering::SeqCst)); + assert!(!counter.load(Ordering::SeqCst)); } #[test] diff --git a/actix-server/src/worker.rs b/actix-server/src/worker.rs index 79f15b16..a974522a 100644 --- a/actix-server/src/worker.rs +++ b/actix-server/src/worker.rs @@ -73,7 +73,7 @@ fn handle_pair( /// On reaching counter limit worker would use `mio::Waker` and `WakerQueue` to wake up `Accept` /// and notify it to update cached `Availability` again to mark worker as able to accept work again. /// -/// Hense a wake up would only happen after `Accept` increment it to limit. +/// Hence, a wake up would only happen after `Accept` increment it to limit. /// And a decrement to limit always wake up `Accept`. #[derive(Clone)] pub(crate) struct Counter { @@ -179,8 +179,9 @@ impl WorkerHandleAccept { /// Handle to worker than can send stop message to worker. /// /// Held by [ServerBuilder](crate::builder::ServerBuilder). +#[derive(Debug)] pub(crate) struct WorkerHandleServer { - pub idx: usize, + idx: usize, tx: UnboundedSender, }