actix/actix-net
1
0
Fork 0
mirror of https://github.com/fafhrd91/actix-net synced 2024-11-27 18:02:58 +01:00
Code Issues Releases Wiki Activity

server: Don't listen for SIGHUP (#389)

Browse Source
This commit is contained in:
Thales 2021-10-03 22:48:10 -03:00 committed by GitHub
parent 80a362712f
commit c3d697df97
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
actix-server/CHANGES.md
View File

@ -3,8 +3,13 @@
## Unreleased - 2021-xx-xx ## Unreleased - 2021-xx-xx
* Remove `config` module. `ServiceConfig`, `ServiceRuntime` public types are removed due to this change. [#349] * Remove `config` module. `ServiceConfig`, `ServiceRuntime` public types are removed due to this change. [#349]
* Remove `ServerBuilder::configure` [#349] * Remove `ServerBuilder::configure` [#349]
* Server no long listens to SIGHUP signal.
It actually did not take any action when receiving SIGHUP, the only thing SIGHUP did was to stop
the Server from receiving any future signal, because the `Signals` future stops on the first
signal received [#389]
[#349]: https://github.com/actix/actix-net/pull/349 [#349]: https://github.com/actix/actix-net/pull/349
[#389]: https://github.com/actix/actix-net/pull/389
## 2.0.0-beta.5 - 2021-04-20 ## 2.0.0-beta.5 - 2021-04-20

1
actix-server/src/builder.rs
View File

@ -335,7 +335,6 @@ impl ServerBuilder {
completion: None, completion: None,
}) })
} }
_ => (),
} }
} }
ServerCommand::Notify(tx) => { ServerCommand::Notify(tx) => {

3
actix-server/src/signals.rs
View File

@ -8,8 +8,6 @@ use crate::server::Server;
#[allow(dead_code)] #[allow(dead_code)]
#[derive(PartialEq, Clone, Copy, Debug)] #[derive(PartialEq, Clone, Copy, Debug)]
pub(crate) enum Signal { pub(crate) enum Signal {
/// SIGHUP
Hup,
/// SIGINT /// SIGINT
Int, Int,
/// SIGTERM /// SIGTERM
@ -41,7 +39,6 @@ impl Signals {
let sig_map = [ let sig_map = [
(unix::SignalKind::interrupt(), Signal::Int), (unix::SignalKind::interrupt(), Signal::Int),
(unix::SignalKind::hangup(), Signal::Hup),
(unix::SignalKind::terminate(), Signal::Term), (unix::SignalKind::terminate(), Signal::Term),
(unix::SignalKind::quit(), Signal::Quit), (unix::SignalKind::quit(), Signal::Quit),
]; ];