2020-11-24 12:37:05 +01:00
|
|
|
use std::{
|
|
|
|
cmp,
|
|
|
|
convert::{TryFrom, TryInto},
|
2021-09-01 10:08:29 +02:00
|
|
|
fmt,
|
|
|
|
str::{self, FromStr},
|
2020-11-24 12:37:05 +01:00
|
|
|
};
|
2019-02-07 22:24:24 +01:00
|
|
|
|
2020-11-24 12:37:05 +01:00
|
|
|
use derive_more::{Display, Error};
|
|
|
|
|
2021-09-01 10:08:29 +02:00
|
|
|
use crate::error::ParseError;
|
|
|
|
|
2020-11-24 12:37:05 +01:00
|
|
|
const MAX_QUALITY: u16 = 1000;
|
|
|
|
const MAX_FLOAT_QUALITY: f32 = 1.0;
|
2019-02-07 22:24:24 +01:00
|
|
|
|
|
|
|
/// Represents a quality used in quality values.
|
|
|
|
///
|
2020-11-24 12:37:05 +01:00
|
|
|
/// Can be created with the [`q`] function.
|
2019-02-07 22:24:24 +01:00
|
|
|
///
|
|
|
|
/// # Implementation notes
|
|
|
|
///
|
|
|
|
/// The quality value is defined as a number between 0 and 1 with three decimal
|
|
|
|
/// places. This means there are 1001 possible values. Since floating point
|
|
|
|
/// numbers are not exact and the smallest floating point data type (`f32`)
|
|
|
|
/// consumes four bytes, hyper uses an `u16` value to store the
|
|
|
|
/// quality internally. For performance reasons you may set quality directly to
|
|
|
|
/// a value between 0 and 1000 e.g. `Quality(532)` matches the quality
|
|
|
|
/// `q=0.532`.
|
|
|
|
///
|
2021-12-02 04:45:04 +01:00
|
|
|
/// [RFC 7231 §5.3.1](https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.1) gives more
|
|
|
|
/// information on quality values in HTTP header fields.
|
2020-11-24 11:08:57 +01:00
|
|
|
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
|
2019-02-07 22:24:24 +01:00
|
|
|
pub struct Quality(u16);
|
|
|
|
|
2020-11-24 12:37:05 +01:00
|
|
|
impl Quality {
|
|
|
|
/// # Panics
|
|
|
|
/// Panics in debug mode when value is not in the range 0.0 <= n <= 1.0.
|
|
|
|
fn from_f32(value: f32) -> Self {
|
|
|
|
// Check that `value` is within range should be done before calling this method.
|
|
|
|
// Just in case, this debug_assert should catch if we were forgetful.
|
|
|
|
debug_assert!(
|
|
|
|
(0.0f32..=1.0f32).contains(&value),
|
|
|
|
"q value must be between 0.0 and 1.0"
|
|
|
|
);
|
|
|
|
|
|
|
|
Quality((value * MAX_QUALITY as f32) as u16)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
impl Default for Quality {
|
|
|
|
fn default() -> Quality {
|
2020-11-24 12:37:05 +01:00
|
|
|
Quality(MAX_QUALITY)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Debug, Clone, Display, Error)]
|
|
|
|
pub struct QualityOutOfBounds;
|
|
|
|
|
|
|
|
impl TryFrom<u16> for Quality {
|
|
|
|
type Error = QualityOutOfBounds;
|
|
|
|
|
|
|
|
fn try_from(value: u16) -> Result<Self, Self::Error> {
|
|
|
|
if (0..=MAX_QUALITY).contains(&value) {
|
|
|
|
Ok(Quality(value))
|
|
|
|
} else {
|
|
|
|
Err(QualityOutOfBounds)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl TryFrom<f32> for Quality {
|
|
|
|
type Error = QualityOutOfBounds;
|
|
|
|
|
|
|
|
fn try_from(value: f32) -> Result<Self, Self::Error> {
|
|
|
|
if (0.0..=MAX_FLOAT_QUALITY).contains(&value) {
|
|
|
|
Ok(Quality::from_f32(value))
|
|
|
|
} else {
|
|
|
|
Err(QualityOutOfBounds)
|
|
|
|
}
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-12-02 04:45:04 +01:00
|
|
|
/// Represents an item with a quality value as defined
|
|
|
|
/// in [RFC 7231 §5.3.1](https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.1).
|
2019-02-07 22:24:24 +01:00
|
|
|
#[derive(Clone, PartialEq, Debug)]
|
|
|
|
pub struct QualityItem<T> {
|
|
|
|
/// The actual contents of the field.
|
|
|
|
pub item: T,
|
|
|
|
/// The quality (client or server preference) for the value.
|
|
|
|
pub quality: Quality,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<T> QualityItem<T> {
|
|
|
|
/// Creates a new `QualityItem` from an item and a quality.
|
|
|
|
/// The item can be of any type.
|
|
|
|
/// The quality should be a value in the range [0, 1].
|
|
|
|
pub fn new(item: T, quality: Quality) -> QualityItem<T> {
|
|
|
|
QualityItem { item, quality }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<T: PartialEq> cmp::PartialOrd for QualityItem<T> {
|
|
|
|
fn partial_cmp(&self, other: &QualityItem<T>) -> Option<cmp::Ordering> {
|
|
|
|
self.quality.partial_cmp(&other.quality)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<T: fmt::Display> fmt::Display for QualityItem<T> {
|
2019-12-07 19:46:51 +01:00
|
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
2019-02-07 22:24:24 +01:00
|
|
|
fmt::Display::fmt(&self.item, f)?;
|
2020-11-24 12:37:05 +01:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
match self.quality.0 {
|
2020-11-24 12:37:05 +01:00
|
|
|
MAX_QUALITY => Ok(()),
|
2019-02-07 22:24:24 +01:00
|
|
|
0 => f.write_str("; q=0"),
|
2019-03-07 06:12:35 +01:00
|
|
|
x => write!(f, "; q=0.{}", format!("{:03}", x).trim_end_matches('0')),
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-01 10:08:29 +02:00
|
|
|
impl<T: FromStr> FromStr for QualityItem<T> {
|
|
|
|
type Err = ParseError;
|
2019-02-07 22:24:24 +01:00
|
|
|
|
2021-09-01 10:08:29 +02:00
|
|
|
fn from_str(qitem_str: &str) -> Result<Self, Self::Err> {
|
2020-11-24 12:37:05 +01:00
|
|
|
if !qitem_str.is_ascii() {
|
2021-09-01 10:08:29 +02:00
|
|
|
return Err(ParseError::Header);
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
2020-11-24 12:37:05 +01:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
// Set defaults used if parsing fails.
|
2020-11-24 12:37:05 +01:00
|
|
|
let mut raw_item = qitem_str;
|
2019-02-07 22:24:24 +01:00
|
|
|
let mut quality = 1f32;
|
|
|
|
|
2020-11-24 12:37:05 +01:00
|
|
|
let parts: Vec<_> = qitem_str.rsplitn(2, ';').map(str::trim).collect();
|
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
if parts.len() == 2 {
|
2020-11-24 12:37:05 +01:00
|
|
|
// example for item with q-factor:
|
|
|
|
//
|
|
|
|
// gzip; q=0.65
|
|
|
|
// ^^^^^^ parts[0]
|
|
|
|
// ^^ start
|
|
|
|
// ^^^^ q_val
|
|
|
|
// ^^^^ parts[1]
|
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
if parts[0].len() < 2 {
|
2020-11-24 12:37:05 +01:00
|
|
|
// Can't possibly be an attribute since an attribute needs at least a name followed
|
|
|
|
// by an equals sign. And bare identifiers are forbidden.
|
2021-09-01 10:08:29 +02:00
|
|
|
return Err(ParseError::Header);
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
2020-11-24 12:37:05 +01:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
let start = &parts[0][0..2];
|
2020-11-24 12:37:05 +01:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
if start == "q=" || start == "Q=" {
|
2020-11-24 12:37:05 +01:00
|
|
|
let q_val = &parts[0][2..];
|
|
|
|
if q_val.len() > 5 {
|
|
|
|
// longer than 5 indicates an over-precise q-factor
|
2021-09-01 10:08:29 +02:00
|
|
|
return Err(ParseError::Header);
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
2020-11-24 12:37:05 +01:00
|
|
|
|
2021-09-01 10:08:29 +02:00
|
|
|
let q_value = q_val.parse::<f32>().map_err(|_| ParseError::Header)?;
|
2020-11-24 12:37:05 +01:00
|
|
|
|
|
|
|
if (0f32..=1f32).contains(&q_value) {
|
|
|
|
quality = q_value;
|
|
|
|
raw_item = parts[1];
|
|
|
|
} else {
|
2021-09-01 10:08:29 +02:00
|
|
|
return Err(ParseError::Header);
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-01 10:08:29 +02:00
|
|
|
let item = raw_item.parse::<T>().map_err(|_| ParseError::Header)?;
|
2020-11-24 12:37:05 +01:00
|
|
|
|
|
|
|
// we already checked above that the quality is within range
|
|
|
|
Ok(QualityItem::new(item, Quality::from_f32(quality)))
|
|
|
|
}
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Convenience function to wrap a value in a `QualityItem`
|
|
|
|
/// Sets `q` to the default 1.0
|
|
|
|
pub fn qitem<T>(item: T) -> QualityItem<T> {
|
2020-11-24 11:08:57 +01:00
|
|
|
QualityItem::new(item, Quality::default())
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Convenience function to create a `Quality` from a float or integer.
|
|
|
|
///
|
|
|
|
/// Implemented for `u16` and `f32`. Panics if value is out of range.
|
2020-11-24 12:37:05 +01:00
|
|
|
pub fn q<T>(val: T) -> Quality
|
|
|
|
where
|
|
|
|
T: TryInto<Quality>,
|
|
|
|
T::Error: fmt::Debug,
|
|
|
|
{
|
|
|
|
// TODO: on next breaking change, handle unwrap differently
|
|
|
|
val.try_into().unwrap()
|
2019-02-07 22:24:24 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use super::*;
|
|
|
|
|
2021-04-01 17:42:18 +02:00
|
|
|
// copy of encoding from actix-web headers
|
2021-11-16 23:10:30 +01:00
|
|
|
#[allow(clippy::enum_variant_names)] // allow Encoding prefix on EncodingExt
|
2021-04-01 17:42:18 +02:00
|
|
|
#[derive(Clone, PartialEq, Debug)]
|
|
|
|
pub enum Encoding {
|
|
|
|
Chunked,
|
|
|
|
Brotli,
|
|
|
|
Gzip,
|
|
|
|
Deflate,
|
|
|
|
Compress,
|
|
|
|
Identity,
|
|
|
|
Trailers,
|
|
|
|
EncodingExt(String),
|
|
|
|
}
|
|
|
|
|
|
|
|
impl fmt::Display for Encoding {
|
|
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
|
|
use Encoding::*;
|
|
|
|
f.write_str(match *self {
|
|
|
|
Chunked => "chunked",
|
|
|
|
Brotli => "br",
|
|
|
|
Gzip => "gzip",
|
|
|
|
Deflate => "deflate",
|
|
|
|
Compress => "compress",
|
|
|
|
Identity => "identity",
|
|
|
|
Trailers => "trailers",
|
|
|
|
EncodingExt(ref s) => s.as_ref(),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-12-01 20:42:02 +01:00
|
|
|
impl str::FromStr for Encoding {
|
2021-04-01 17:42:18 +02:00
|
|
|
type Err = crate::error::ParseError;
|
|
|
|
fn from_str(s: &str) -> Result<Encoding, crate::error::ParseError> {
|
|
|
|
use Encoding::*;
|
|
|
|
match s {
|
|
|
|
"chunked" => Ok(Chunked),
|
|
|
|
"br" => Ok(Brotli),
|
|
|
|
"deflate" => Ok(Deflate),
|
|
|
|
"gzip" => Ok(Gzip),
|
|
|
|
"compress" => Ok(Compress),
|
|
|
|
"identity" => Ok(Identity),
|
|
|
|
"trailers" => Ok(Trailers),
|
|
|
|
_ => Ok(EncodingExt(s.to_owned())),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_fmt_q_1() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x = qitem(Chunked);
|
|
|
|
assert_eq!(format!("{}", x), "chunked");
|
|
|
|
}
|
|
|
|
#[test]
|
|
|
|
fn test_quality_item_fmt_q_0001() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x = QualityItem::new(Chunked, Quality(1));
|
|
|
|
assert_eq!(format!("{}", x), "chunked; q=0.001");
|
|
|
|
}
|
|
|
|
#[test]
|
|
|
|
fn test_quality_item_fmt_q_05() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
// Custom value
|
|
|
|
let x = QualityItem {
|
|
|
|
item: EncodingExt("identity".to_owned()),
|
|
|
|
quality: Quality(500),
|
|
|
|
};
|
|
|
|
assert_eq!(format!("{}", x), "identity; q=0.5");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_quality_item_fmt_q_0() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
// Custom value
|
|
|
|
let x = QualityItem {
|
|
|
|
item: EncodingExt("identity".to_owned()),
|
|
|
|
quality: Quality(0),
|
|
|
|
};
|
|
|
|
assert_eq!(x.to_string(), "identity; q=0");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str1() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x: Result<QualityItem<Encoding>, _> = "chunked".parse();
|
|
|
|
assert_eq!(
|
|
|
|
x.unwrap(),
|
|
|
|
QualityItem {
|
|
|
|
item: Chunked,
|
|
|
|
quality: Quality(1000),
|
|
|
|
}
|
|
|
|
);
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str2() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x: Result<QualityItem<Encoding>, _> = "chunked; q=1".parse();
|
|
|
|
assert_eq!(
|
|
|
|
x.unwrap(),
|
|
|
|
QualityItem {
|
|
|
|
item: Chunked,
|
|
|
|
quality: Quality(1000),
|
|
|
|
}
|
|
|
|
);
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str3() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x: Result<QualityItem<Encoding>, _> = "gzip; q=0.5".parse();
|
|
|
|
assert_eq!(
|
|
|
|
x.unwrap(),
|
|
|
|
QualityItem {
|
|
|
|
item: Gzip,
|
|
|
|
quality: Quality(500),
|
|
|
|
}
|
|
|
|
);
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str4() {
|
2021-04-01 17:42:18 +02:00
|
|
|
use Encoding::*;
|
2019-02-07 22:24:24 +01:00
|
|
|
let x: Result<QualityItem<Encoding>, _> = "gzip; q=0.273".parse();
|
|
|
|
assert_eq!(
|
|
|
|
x.unwrap(),
|
|
|
|
QualityItem {
|
|
|
|
item: Gzip,
|
|
|
|
quality: Quality(273),
|
|
|
|
}
|
|
|
|
);
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str5() {
|
|
|
|
let x: Result<QualityItem<Encoding>, _> = "gzip; q=0.2739999".parse();
|
|
|
|
assert!(x.is_err());
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_from_str6() {
|
|
|
|
let x: Result<QualityItem<Encoding>, _> = "gzip; q=2".parse();
|
|
|
|
assert!(x.is_err());
|
|
|
|
}
|
2021-04-01 17:42:18 +02:00
|
|
|
|
2019-02-07 22:24:24 +01:00
|
|
|
#[test]
|
|
|
|
fn test_quality_item_ordering() {
|
|
|
|
let x: QualityItem<Encoding> = "gzip; q=0.5".parse().ok().unwrap();
|
|
|
|
let y: QualityItem<Encoding> = "gzip; q=0.273".parse().ok().unwrap();
|
|
|
|
let comparision_result: bool = x.gt(&y);
|
|
|
|
assert!(comparision_result)
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_quality() {
|
|
|
|
assert_eq!(q(0.5), Quality(500));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-11-24 12:37:05 +01:00
|
|
|
#[should_panic]
|
2019-02-07 22:24:24 +01:00
|
|
|
fn test_quality_invalid() {
|
|
|
|
q(-1.0);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-11-24 12:37:05 +01:00
|
|
|
#[should_panic]
|
2019-02-07 22:24:24 +01:00
|
|
|
fn test_quality_invalid2() {
|
|
|
|
q(2.0);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fuzzing_bugs() {
|
|
|
|
assert!("99999;".parse::<QualityItem<String>>().is_err());
|
|
|
|
assert!("\x0d;;;=\u{d6aa}==".parse::<QualityItem<String>>().is_err())
|
|
|
|
}
|
|
|
|
}
|