From 30db78c19cf8c3e65a4cfefdeb6f8ccf15cec921 Mon Sep 17 00:00:00 2001
From: Nikolay Kim <fafhrd91@gmail.com>
Date: Mon, 8 Oct 2018 07:55:01 -0700
Subject: [PATCH] use TakeItem instead of TakeRequest

---
 src/h1/mod.rs     |  3 +-
 src/h1/service.rs | 81 ++---------------------------------------------
 tests/test_ws.rs  |  3 +-
 3 files changed, 6 insertions(+), 81 deletions(-)

diff --git a/src/h1/mod.rs b/src/h1/mod.rs
index 266ebf39..634136a4 100644
--- a/src/h1/mod.rs
+++ b/src/h1/mod.rs
@@ -6,5 +6,6 @@ mod encoder;
 mod service;
 
 pub use self::codec::{Codec, InMessage, OutMessage};
+pub use self::decoder::{PayloadDecoder, RequestDecoder};
 pub use self::dispatcher::Dispatcher;
-pub use self::service::{H1Service, H1ServiceHandler, TakeRequest};
+pub use self::service::{H1Service, H1ServiceHandler};
diff --git a/src/h1/service.rs b/src/h1/service.rs
index de24f52c..a7261df1 100644
--- a/src/h1/service.rs
+++ b/src/h1/service.rs
@@ -2,17 +2,15 @@ use std::fmt::Debug;
 use std::marker::PhantomData;
 use std::net;
 
-use actix_net::codec::Framed;
 use actix_net::service::{IntoNewService, NewService, Service};
-use futures::{future, Async, Future, Poll, Stream};
+use futures::{Async, Future, Poll};
 use tokio_io::{AsyncRead, AsyncWrite};
 
 use config::{KeepAlive, ServiceConfig};
-use error::{DispatchError, ParseError};
+use error::DispatchError;
 use request::Request;
 use response::Response;
 
-use super::codec::{Codec, InMessage};
 use super::dispatcher::Dispatcher;
 
 /// `NewService` implementation for HTTP1 transport
@@ -257,78 +255,3 @@ where
         Dispatcher::new(req, self.cfg.clone(), self.srv.clone())
     }
 }
-
-/// `NewService` that implements, read one request from framed object feature.
-pub struct TakeRequest<T> {
-    _t: PhantomData<T>,
-}
-
-impl<T> TakeRequest<T> {
-    /// Create new `TakeRequest` instance.
-    pub fn new() -> Self {
-        TakeRequest { _t: PhantomData }
-    }
-}
-
-impl<T> NewService for TakeRequest<T>
-where
-    T: AsyncRead + AsyncWrite,
-{
-    type Request = Framed<T, Codec>;
-    type Response = (Option<InMessage>, Framed<T, Codec>);
-    type Error = ParseError;
-    type InitError = ();
-    type Service = TakeRequestService<T>;
-    type Future = future::FutureResult<Self::Service, Self::InitError>;
-
-    fn new_service(&self) -> Self::Future {
-        future::ok(TakeRequestService { _t: PhantomData })
-    }
-}
-
-/// `NewService` that implements, read one request from framed object feature.
-pub struct TakeRequestService<T> {
-    _t: PhantomData<T>,
-}
-
-impl<T> Service for TakeRequestService<T>
-where
-    T: AsyncRead + AsyncWrite,
-{
-    type Request = Framed<T, Codec>;
-    type Response = (Option<InMessage>, Framed<T, Codec>);
-    type Error = ParseError;
-    type Future = TakeRequestServiceResponse<T>;
-
-    fn poll_ready(&mut self) -> Poll<(), Self::Error> {
-        Ok(Async::Ready(()))
-    }
-
-    fn call(&mut self, framed: Self::Request) -> Self::Future {
-        TakeRequestServiceResponse {
-            framed: Some(framed),
-        }
-    }
-}
-
-pub struct TakeRequestServiceResponse<T>
-where
-    T: AsyncRead + AsyncWrite,
-{
-    framed: Option<Framed<T, Codec>>,
-}
-
-impl<T> Future for TakeRequestServiceResponse<T>
-where
-    T: AsyncRead + AsyncWrite,
-{
-    type Item = (Option<InMessage>, Framed<T, Codec>);
-    type Error = ParseError;
-
-    fn poll(&mut self) -> Poll<Self::Item, Self::Error> {
-        match self.framed.as_mut().unwrap().poll()? {
-            Async::Ready(item) => Ok(Async::Ready((item, self.framed.take().unwrap()))),
-            Async::NotReady => Ok(Async::NotReady),
-        }
-    }
-}
diff --git a/tests/test_ws.rs b/tests/test_ws.rs
index a2a18ff2..8a109874 100644
--- a/tests/test_ws.rs
+++ b/tests/test_ws.rs
@@ -12,6 +12,7 @@ use actix_net::codec::Framed;
 use actix_net::framed::IntoFramed;
 use actix_net::server::Server;
 use actix_net::service::NewServiceExt;
+use actix_net::stream::TakeItem;
 use actix_web::{test, ws as web_ws};
 use bytes::Bytes;
 use futures::future::{ok, Either};
@@ -36,7 +37,7 @@ fn test_simple() {
         Server::new()
             .bind("test", addr, move || {
                 IntoFramed::new(|| h1::Codec::new(false))
-                    .and_then(h1::TakeRequest::new().map_err(|_| ()))
+                    .and_then(TakeItem::new().map_err(|_| ()))
                     .and_then(|(req, framed): (_, Framed<_, _>)| {
                         // validate request
                         if let Some(h1::InMessage::MessageWithPayload(req)) = req {