actix/actix-web
1
0
Fork 0
mirror of https://github.com/fafhrd91/actix-web synced 2025-01-31 11:02:08 +01:00
Code Issues Releases Wiki Activity

fix limit not working on HttpMessageBody::limit (#1938)

Browse Source
This commit is contained in:
fakeshadow 2021-01-27 02:49:57 -08:00 committed by GitHub
parent c201c15f8c
commit 51e54dac8b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/types/payload.rs
View File

@ -289,10 +289,12 @@ impl HttpMessageBody {
if let Some(l) = req.headers().get(&header::CONTENT_LENGTH) { if let Some(l) = req.headers().get(&header::CONTENT_LENGTH) {
match l.to_str() { match l.to_str() {
Ok(s) => match s.parse::<usize>() { Ok(s) => match s.parse::<usize>() {
Ok(l) if l > DEFAULT_CONFIG_LIMIT => { Ok(l) => {
err = Some(PayloadError::Overflow) if l > DEFAULT_CONFIG_LIMIT {
err = Some(PayloadError::Overflow);
}
length = Some(l)
} }
Ok(l) => length = Some(l),
Err(_) => err = Some(PayloadError::UnknownLength), Err(_) => err = Some(PayloadError::UnknownLength),
}, },
Err(_) => err = Some(PayloadError::UnknownLength), Err(_) => err = Some(PayloadError::UnknownLength),
@ -316,9 +318,11 @@ impl HttpMessageBody {
/// Change max size of payload. By default max size is 256kB /// Change max size of payload. By default max size is 256kB
pub fn limit(mut self, limit: usize) -> Self { pub fn limit(mut self, limit: usize) -> Self {
if let Some(l) = self.length { if let Some(l) = self.length {
if l > limit { self.err = if l > limit {
self.err = Some(PayloadError::Overflow); Some(PayloadError::Overflow)
} } else {
None
};
} }
self.limit = limit; self.limit = limit;
self self