From a03a2a0076d16dd80467b6c91697baabfeb66ddf Mon Sep 17 00:00:00 2001
From: Rob Ede <robjtede@icloud.com>
Date: Thu, 10 Mar 2022 02:54:06 +0000
Subject: [PATCH] deprecate `NamedFile::set_status_code`

---
 actix-files/src/lib.rs   | 27 +++++++++++++++++++++++++--
 actix-files/src/named.rs | 17 ++++++-----------
 2 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/actix-files/src/lib.rs b/actix-files/src/lib.rs
index 41113f2ab..40327e5e8 100644
--- a/actix-files/src/lib.rs
+++ b/actix-files/src/lib.rs
@@ -364,20 +364,43 @@ mod tests {
         );
     }
 
+    #[allow(deprecated)]
     #[actix_rt::test]
-    async fn test_named_file_status_code_text() {
-        let mut file = NamedFile::open_async("Cargo.toml")
+    async fn status_code_customize_same_output() {
+        let file1 = NamedFile::open_async("Cargo.toml")
             .await
             .unwrap()
             .set_status_code(StatusCode::NOT_FOUND);
+
+        let file2 = NamedFile::open_async("Cargo.toml")
+            .await
+            .unwrap()
+            .customize()
+            .with_status(StatusCode::NOT_FOUND);
+
+        let req = TestRequest::default().to_http_request();
+        let res1 = file1.respond_to(&req);
+        let res2 = file2.respond_to(&req);
+
+        assert_eq!(res1.status(), StatusCode::NOT_FOUND);
+        assert_eq!(res2.status(), StatusCode::NOT_FOUND);
+    }
+
+    #[actix_rt::test]
+    async fn test_named_file_status_code_text() {
+        let mut file = NamedFile::open_async("Cargo.toml").await.unwrap();
+
         {
             file.file();
             let _f: &File = &file;
         }
+
         {
             let _f: &mut File = &mut file;
         }
 
+        let file = file.customize().with_status(StatusCode::NOT_FOUND);
+
         let req = TestRequest::default().to_http_request();
         let resp = file.respond_to(&req);
         assert_eq!(
diff --git a/actix-files/src/named.rs b/actix-files/src/named.rs
index 459670c3a..5580e6f7e 100644
--- a/actix-files/src/named.rs
+++ b/actix-files/src/named.rs
@@ -298,20 +298,15 @@ impl NamedFile {
         self.encoding
     }
 
-    /// Returns the status code for serving this file.
-    #[inline]
-    pub fn status_code(&self) -> &StatusCode {
-        &self.status_code
-    }
-
-    /// Set response **Status Code**
+    /// Set response status code.
+    #[deprecated(since = "0.7.0", note = "Prefer `Responder::customize()`.")]
     pub fn set_status_code(mut self, status: StatusCode) -> Self {
         self.status_code = status;
         self
     }
 
-    /// Set the MIME Content-Type for serving this file. By default the Content-Type is inferred
-    /// from the filename extension.
+    /// Sets the `Content-Type` header that will be used when serving this file. By default the
+    /// `Content-Type` is inferred from the filename extension.
     #[inline]
     pub fn set_content_type(mut self, mime_type: Mime) -> Self {
         self.content_type = mime_type;
@@ -332,9 +327,9 @@ impl NamedFile {
         self
     }
 
-    /// Disable `Content-Disposition` header.
+    /// Disables `Content-Disposition` header.
     ///
-    /// By default Content-Disposition` header is enabled.
+    /// By default, the `Content-Disposition` header is sent.
     #[inline]
     pub fn disable_content_disposition(mut self) -> Self {
         self.flags.remove(Flags::CONTENT_DISPOSITION);