actix/actix-web
1
0
Fork 0
mirror of https://github.com/fafhrd91/actix-web synced 2024-11-27 17:52:56 +01:00
Code Issues Releases Wiki Activity

replace unsafe blocks in write_usize helper

Browse Source
This commit is contained in:
Rob Ede 2020-02-16 15:20:25 +00:00
parent 31a3515e90
commit f266b44cb0
No known key found for this signature in database
GPG Key ID: C2A3B36E841A91E6
2 changed files with 55 additions and 108 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
actix-http/benches/content-length.rs
View File

@ -34,16 +34,8 @@ criterion_group!(benches, bench_write_content_length);
criterion_main!(benches); criterion_main!(benches);
mod _new { mod _new {
use std::{ptr, slice};
use bytes::{BufMut, BytesMut}; use bytes::{BufMut, BytesMut};
const DEC_DIGITS_LUT: &[u8] = b"0001020304050607080910111213141516171819\
2021222324252627282930313233343536373839\
4041424344454647484950515253545556575859\
6061626364656667686970717273747576777879\
8081828384858687888990919293949596979899";
const DIGITS_START: u8 = b'0'; const DIGITS_START: u8 = b'0';
/// NOTE: bytes object has to contain enough space /// NOTE: bytes object has to contain enough space
@ -94,63 +86,29 @@ mod _new {
bytes.put_slice(b"\r\n"); bytes.put_slice(b"\r\n");
} }
pub(crate) fn write_usize(mut n: usize, bytes: &mut BytesMut) { fn write_usize(n: usize, bytes: &mut BytesMut) {
let mut curr: isize = 39; let mut n = n;
let mut buf = [0u8; 39];
let buf_ptr = buf.as_mut_ptr(); // 20 chars is max length of a usize (2^64)
let lut_ptr = DEC_DIGITS_LUT.as_ptr(); // digits will be added to the buffer from lsd to msd
let mut buf = BytesMut::with_capacity(20);
// eagerly decode 4 characters at a time while n > 9 {
while n >= 10_000 { // "pop" the least-significant digit
let rem = (n % 10_000) as isize; let lsd = (n % 10) as u8;
n /= 10_000;
let d1 = (rem / 100) << 1; // remove the lsd from n
let d2 = (rem % 100) << 1; n = n / 10;
curr -= 4;
unsafe { buf.put_u8(DIGITS_START + lsd);
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
ptr::copy_nonoverlapping(
lut_ptr.offset(d2),
buf_ptr.offset(curr + 2),
2,
);
}
} }
// if we reach here numbers are <= 9999, so at most 4 chars long // put msd to result buffer
let mut n = n as isize; // possibly reduce 64bit math bytes.put_u8(DIGITS_START + (n as u8));
// decode 2 more chars, if > 2 chars // put, in reverse (msd to lsd), remaining digits to buffer
if n >= 100 { for i in (0..buf.len()).rev() {
let d1 = (n % 100) << 1; bytes.put_u8(buf[i]);
n /= 100;
curr -= 2;
unsafe {
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
}
}
// decode last 1 or 2 chars
if n < 10 {
curr -= 1;
unsafe {
*buf_ptr.offset(curr) = (n as u8) + b'0';
}
} else {
let d1 = n << 1;
curr -= 2;
unsafe {
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
}
}
unsafe {
bytes.extend_from_slice(slice::from_raw_parts(
buf_ptr.offset(curr),
39 - curr as usize,
));
} }
} }
} }

85
actix-http/src/helpers.rs
View File

@ -1,4 +1,4 @@
use std::{io, ptr, slice}; use std::{io, ptr};
use bytes::{BufMut, BytesMut}; use bytes::{BufMut, BytesMut};
use http::Version; use http::Version;
@ -107,59 +107,29 @@ pub fn write_content_length(n: usize, bytes: &mut BytesMut) {
bytes.put_slice(b"\r\n"); bytes.put_slice(b"\r\n");
} }
pub(crate) fn write_usize(mut n: usize, bytes: &mut BytesMut) { pub(crate) fn write_usize(n: usize, bytes: &mut BytesMut) {
let mut curr: isize = 39; let mut n = n;
let mut buf = [0u8; 39];
let buf_ptr = buf.as_mut_ptr(); // 20 chars is max length of a usize (2^64)
let lut_ptr = DEC_DIGITS_LUT.as_ptr(); // digits will be added to the buffer from lsd to msd
let mut buf = BytesMut::with_capacity(20);
// eagerly decode 4 characters at a time while n > 9 {
while n >= 10_000 { // "pop" the least-significant digit
let rem = (n % 10_000) as isize; let lsd = (n % 10) as u8;
n /= 10_000;
let d1 = (rem / 100) << 1; // remove the lsd from n
let d2 = (rem % 100) << 1; n = n / 10;
curr -= 4;
unsafe { buf.put_u8(DIGITS_START + lsd);
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
ptr::copy_nonoverlapping(lut_ptr.offset(d2), buf_ptr.offset(curr + 2), 2);
}
} }
// if we reach here numbers are <= 9999, so at most 4 chars long // put msd to result buffer
let mut n = n as isize; // possibly reduce 64bit math bytes.put_u8(DIGITS_START + (n as u8));
// decode 2 more chars, if > 2 chars // put, in reverse (msd to lsd), remaining digits to buffer
if n >= 100 { for i in (0..buf.len()).rev() {
let d1 = (n % 100) << 1; bytes.put_u8(buf[i]);
n /= 100;
curr -= 2;
unsafe {
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
}
}
// decode last 1 or 2 chars
if n < 10 {
curr -= 1;
unsafe {
*buf_ptr.offset(curr) = (n as u8) + b'0';
}
} else {
let d1 = n << 1;
curr -= 2;
unsafe {
ptr::copy_nonoverlapping(lut_ptr.offset(d1), buf_ptr.offset(curr), 2);
}
}
unsafe {
bytes.extend_from_slice(slice::from_raw_parts(
buf_ptr.offset(curr),
39 - curr as usize,
));
} }
} }
@ -230,5 +200,24 @@ mod tests {
bytes.reserve(50); bytes.reserve(50);
write_content_length(59094, &mut bytes); write_content_length(59094, &mut bytes);
assert_eq!(bytes.split().freeze(), b"\r\ncontent-length: 59094\r\n"[..]); assert_eq!(bytes.split().freeze(), b"\r\ncontent-length: 59094\r\n"[..]);
bytes.reserve(50);
write_content_length(590947, &mut bytes);
assert_eq!(
bytes.split().freeze(),
b"\r\ncontent-length: 590947\r\n"[..]
);
bytes.reserve(50);
write_content_length(5909471, &mut bytes);
assert_eq!(
bytes.split().freeze(),
b"\r\ncontent-length: 5909471\r\n"[..]
);
bytes.reserve(50);
write_content_length(59094718, &mut bytes);
assert_eq!(
bytes.split().freeze(),
b"\r\ncontent-length: 59094718\r\n"[..]
);
} }
} }