1
0
mirror of https://github.com/actix/examples synced 2025-03-14 08:46:26 +01:00

Perform unused validation in async_ex1 example (#83)

This commit is contained in:
Allen 2019-03-09 20:10:39 -08:00 committed by Douman
parent 5c8aaba5f9
commit 4d26988edf

View File

@ -29,9 +29,9 @@ extern crate validator;
use actix_web::{ use actix_web::{
client, http::Method, server, App, AsyncResponder, Error, HttpMessage, HttpResponse, client, http::Method, server, App, AsyncResponder, Error, HttpMessage, HttpResponse,
Json, Json, error::ErrorBadRequest,
}; };
use futures::{future::ok as fut_ok, Future}; use futures::{future::ok as fut_ok, future::result as fut_result, Future};
use std::collections::HashMap; use std::collections::HashMap;
use std::time::Duration; use std::time::Duration;
use validator::Validate; use validator::Validate;
@ -63,6 +63,9 @@ struct HttpBinResponse {
/// post json to httpbin, get it back in the response body, return deserialized /// post json to httpbin, get it back in the response body, return deserialized
fn step_x_v1(data: SomeData) -> Box<Future<Item = SomeData, Error = Error>> { fn step_x_v1(data: SomeData) -> Box<Future<Item = SomeData, Error = Error>> {
Box::new( Box::new(
fut_result(data.validate()) // <- call .validate() on data to validate the parameters
.map_err(ErrorBadRequest) // - convert ValidationErrors to an Error
.and_then(|_| {
client::ClientRequest::post("https://httpbin.org/post") client::ClientRequest::post("https://httpbin.org/post")
.json(data).unwrap() .json(data).unwrap()
.send() .send()
@ -75,7 +78,8 @@ fn step_x_v1(data: SomeData) -> Box<Future<Item = SomeData, Error = Error>> {
let resp: HttpBinResponse = serde_json::from_slice(&body).unwrap(); let resp: HttpBinResponse = serde_json::from_slice(&body).unwrap();
fut_ok(resp.json) fut_ok(resp.json)
}) })
), )
})
) )
} }
@ -102,6 +106,9 @@ fn create_something_v1(
/// post json to httpbin, get it back in the response body, return deserialized /// post json to httpbin, get it back in the response body, return deserialized
fn step_x_v2(data: SomeData) -> impl Future<Item = SomeData, Error = Error> { fn step_x_v2(data: SomeData) -> impl Future<Item = SomeData, Error = Error> {
fut_result(data.validate()) // <- call .validate() on data to validate the parameters
.map_err(ErrorBadRequest) // - convert ValidationErrors to an Error
.and_then(|_| {
client::ClientRequest::post("https://httpbin.org/post") client::ClientRequest::post("https://httpbin.org/post")
.json(data).unwrap() .json(data).unwrap()
.send() .send()
@ -115,6 +122,7 @@ fn step_x_v2(data: SomeData) -> impl Future<Item = SomeData, Error = Error> {
fut_ok(resp.json) fut_ok(resp.json)
}) })
) )
})
} }
fn create_something_v2( fn create_something_v2(