actix/actix-extras
1
0
Fork 0
mirror of https://github.com/actix/actix-extras.git synced 2025-02-23 02:43:16 +01:00
Code Issues Releases Wiki Activity

Clippy lints

Browse Source
This commit is contained in:
Luca Palmieri 2022-12-19 10:56:18 +01:00
parent 8e5b09b379
commit d23e48b4ee
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/root_span_builder.rs
View File

@ -49,8 +49,8 @@ impl RootSpanBuilder for DefaultRootSpanBuilder {
handle_error(span, response.status(), error.as_response_error()); handle_error(span, response.status(), error.as_response_error());
} else { } else {
let code: i32 = response.response().status().as_u16().into(); let code: i32 = response.response().status().as_u16().into();
span.record("http.status_code", &code); span.record("http.status_code", code);
span.record("otel.status_code", &"OK"); span.record("otel.status_code", "OK");
} }
} }
Err(error) => { Err(error) => {
@ -63,17 +63,17 @@ impl RootSpanBuilder for DefaultRootSpanBuilder {
fn handle_error(span: Span, status_code: StatusCode, response_error: &dyn ResponseError) { fn handle_error(span: Span, status_code: StatusCode, response_error: &dyn ResponseError) {
// pre-formatting errors is a workaround for https://github.com/tokio-rs/tracing/issues/1565 // pre-formatting errors is a workaround for https://github.com/tokio-rs/tracing/issues/1565
let display = format!("{}", response_error); let display = format!("{response_error}");
let debug = format!("{:?}", response_error); let debug = format!("{response_error:?}");
span.record("exception.message", &tracing::field::display(display)); span.record("exception.message", &tracing::field::display(display));
span.record("exception.details", &tracing::field::display(debug)); span.record("exception.details", &tracing::field::display(debug));
let code: i32 = status_code.as_u16().into(); let code: i32 = status_code.as_u16().into();
span.record("http.status_code", &code); span.record("http.status_code", code);
if status_code.is_client_error() { if status_code.is_client_error() {
span.record("otel.status_code", &"OK"); span.record("otel.status_code", "OK");
} else { } else {
span.record("otel.status_code", &"ERROR"); span.record("otel.status_code", "ERROR");
} }
} }

2
src/root_span_macro.rs
View File

@ -192,7 +192,7 @@ pub mod private {
Version::HTTP_11 => "1.1".into(), Version::HTTP_11 => "1.1".into(),
Version::HTTP_2 => "2.0".into(), Version::HTTP_2 => "2.0".into(),
Version::HTTP_3 => "3.0".into(), Version::HTTP_3 => "3.0".into(),
other => format!("{:?}", other).into(), other => format!("{other:?}").into(),
} }
} }