Brandur
f89b7a9bb8
Merge pull request #194 from actix/brandur-allowed-origin-into
...
Let CSRF's `allowed_origin()` be specified as a type supporting `Into<String>`
2018-04-21 10:37:18 -07:00
Brandur
59244b203c
Let CSRF's allowed_origin() be specified as a type supporting Into<String>
...
A very minor addition: I'm using this middleware on specific resources,
and given a non-static string, I often have to `clone()` already to get
a string into a closure. Take this code for example:
``` rust
let server = actix_web::server::new(move || {
let csrf_origin_graphql = csrf_origin.clone();
...
.resource("/graphql", move |r| {
r.middleware(
csrf::CsrfFilter::new().allowed_origin(csrf_origin_graphql.as_str()),
);
r.method(Method::POST).a(graphql::handlers::graphql_post);
})
```
Letting `allowed_origin()` take an `Into<String>` instead of `&str` would
prevent a second `clone()` in the code above, and also make the code a little
nicer to read (you eliminate the `.as_str()` above). This is a pattern that
seems to be common throughout actix-web already anyway, so it should also be
fine to have here.
2018-04-21 08:41:06 -07:00
Nikolay Kim
2adf8a3a48
add changelog entry
2018-04-21 07:56:11 -07:00
Nikolay Kim
805dbea8e7
Merge pull request #192 from fuchsnj/check_if_close_code_exists
...
check if close code exists before reading it
2018-04-21 07:54:25 -07:00
Nathan Fox
dc9a24a189
add websocket empty close status test
2018-04-20 21:55:07 -04:00
Nathan Fox
5528cf62f0
check if close code exists before reading it
2018-04-20 21:30:18 -04:00
Nikolay Kim
9880a95603
Merge pull request #189 from drklee3/patch-1
...
Update README links to use new guide
2018-04-19 19:24:40 -07:00
Derrick Lee
2579c49865
Update README links to use new guide
2018-04-19 18:51:01 -07:00
Nikolay Kim
01a0f3f5a0
remove unused dependency
2018-04-19 09:54:22 -07:00
Nikolay Kim
2c8d987241
Use Display formatting for InternalError Display implementation #188
2018-04-19 07:55:09 -07:00
Nikolay Kim
813d1d6e66
doc strings layout
2018-04-18 20:41:03 -07:00
Nikolay Kim
48b02abee7
fmt
2018-04-18 20:16:29 -07:00
Nikolay Kim
ce1081432b
export session module
2018-04-18 20:11:49 -07:00
Nikolay Kim
e9bdba57a0
Add identity service middleware
2018-04-18 19:05:24 -07:00
Nikolay Kim
f907be585e
Middleware response() is not invoked if there was an error in async handler #187
2018-04-18 14:15:53 -07:00
Nikolay Kim
022f9800ed
formatting
2018-04-18 10:49:03 -07:00
Nikolay Kim
a9a54ac4c6
prep release
2018-04-18 10:45:59 -07:00
Nikolay Kim
50b9fee3a7
Merge branch 'master' of github.com:actix/actix-web
2018-04-17 16:24:02 -07:00
Nikolay Kim
bf9a90293f
fix doc strings
2018-04-17 16:22:25 -07:00
Nikolay Kim
17ec3a3a26
Merge pull request #185 from kornelski/master
...
Replace use of try!() with ?
2018-04-17 15:57:09 -07:00
Kornel
5b4b885fd6
Replace use of try!() with ?
2018-04-17 23:20:47 +01:00
Nikolay Kim
65b8197876
better doc string for Application::with_state()
2018-04-17 13:59:55 -07:00
Nikolay Kim
a826d113ee
add custom request path quoter #182
2018-04-17 12:55:13 -07:00
Nikolay Kim
3a79505a44
update doc string
2018-04-17 07:51:06 -07:00
Nikolay Kim
5f3a7a6a52
Merge pull request #184 from ivanovaleksey/patch-1
...
Fix route in App::resource example
2018-04-17 07:49:09 -07:00
Aleksey Ivanov
6a7b097bcf
Fix route in App::resource example
2018-04-17 16:01:34 +03:00
Nikolay Kim
30a36bed9d
fix doc example
2018-04-16 09:50:37 -07:00
Nikolay Kim
79818560b2
cleanup doc strings; prepare release
2018-04-16 09:30:59 -07:00
Nikolay Kim
58cc0dfbc5
Fix Client Request with custom Body Stream halting on certain size requests #176
2018-04-15 10:22:09 -07:00
Nikolay Kim
a9ea649348
Allow to configure StaticFiles CpuPool, via static method or env variable
2018-04-13 19:46:14 -07:00
Nikolay Kim
634c5723a0
update changelog
2018-04-13 19:19:30 -07:00
Nikolay Kim
a5b5ff0894
update doc strings
2018-04-13 19:14:14 -07:00
Nikolay Kim
5140fea8d1
allow to use castom error handler for json extractor
2018-04-13 19:10:42 -07:00
Nikolay Kim
333b4f57d3
use different directory for tests
2018-04-13 17:00:18 -07:00
Nikolay Kim
827ca5eada
remove skeptic tests
2018-04-13 16:36:39 -07:00
Nikolay Kim
ebc1f6eff9
drop skeptic
2018-04-13 16:21:57 -07:00
Nikolay Kim
a8567da3e2
move guide to separate repo; update links
2018-04-13 16:20:23 -07:00
Nikolay Kim
113f5ad1a8
add rustfmt config
2018-04-13 16:02:01 -07:00
Nikolay Kim
95f6277007
fix typo
2018-04-13 14:36:07 -07:00
Nikolay Kim
22c776f46e
Fix StaticFiles does not support percent encoded paths #177
2018-04-13 10:13:12 -07:00
Nikolay Kim
c0976bfa17
fix test
2018-04-12 21:28:17 -07:00
Nikolay Kim
5e9ec4299c
fix workspace links
2018-04-12 20:52:30 -07:00
Nikolay Kim
e05aba65de
examples moved to separate repo
2018-04-12 20:31:58 -07:00
Nikolay Kim
c5b18c6d30
prepare release
2018-04-12 16:03:22 -07:00
Nikolay Kim
94c5bb5cdd
add helper method for returning inner value
2018-04-12 15:55:15 -07:00
Nikolay Kim
2ca0ea70c4
use one default cpu pool for StaticFiles #174
2018-04-12 15:50:20 -07:00
Nikolay Kim
0b01884fca
add timeouts stats to client connector
2018-04-12 13:08:13 -07:00
Nikolay Kim
83168731fc
update user guide content compression section
2018-04-12 09:54:35 -07:00
Nikolay Kim
7295846426
Merge pull request #173 from jannic/pr
...
fix end-of-stream handling in parse_payload
2018-04-12 09:30:26 -07:00
Jan Niehusmann
72bc1546c4
fix end-of-stream handling in parse_payload
...
parse_payload can be called with a pre-filled buf.
In this case, it's totaly fine for read_from_io to return
sync::Ready(0) while buf is not empty. This is not an
PayloadError::Incomplete.
So, move the check for PayloadError::Incomplete down to the
decoding code: If the decoder is not ready, but the input stream
is finished, PayloadError::Incomplete will be returned.
2018-04-12 09:47:32 +02:00
